Skip to content

[release-0.4] Fix remove redundant component label added for backward compatibility with upgrade tests#1193

Merged
shivamerla merged 1 commit into
kubernetes-sigs:release-0.4from
k8s-infra-cherrypick-robot:cherry-pick-1187-to-release-0.4
Jun 11, 2026
Merged

[release-0.4] Fix remove redundant component label added for backward compatibility with upgrade tests#1193
shivamerla merged 1 commit into
kubernetes-sigs:release-0.4from
k8s-infra-cherrypick-robot:cherry-pick-1187-to-release-0.4

Conversation

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #1187

/assign shivamerla

Resolved an issue where redundant component labels caused errors when Helm templates were rendered with strict parsing in GitOps tools such as ArgoCD.

… with upgrade tests

* As part of GitHub issue kubernetes-sigs#1079 we had introduced redundant component label in both kubelet plugin and CD controller.
  This was mainly for compatibility with upgrade tests (checkpoint validation)
* However, this caused duplicate keys to be rendered and parser validation failures with GitOps like ArgoCD/FluxCD.
* Now that we have a stable release in upstream registries, we can safely remove this label with previous name.

Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 11, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2026
@shivamerla

Copy link
Copy Markdown
Contributor

/lgtm
/approve
/skip tests

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: a0710376533982ef817fbdaf833880e80c770746

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, shivamerla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2026
@shivamerla shivamerla merged commit fa87354 into kubernetes-sigs:release-0.4 Jun 11, 2026
11 of 13 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in DRA Driver for NVIDIA GPUs Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants