Skip to content

remove redundant error wrapping#1181

Open
mesutoezdil wants to merge 1 commit into
kubernetes-sigs:mainfrom
mesutoezdil:cleanup-redundant-wrapping
Open

remove redundant error wrapping#1181
mesutoezdil wants to merge 1 commit into
kubernetes-sigs:mainfrom
mesutoezdil:cleanup-redundant-wrapping

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jun 8, 2026

Copy link
Copy Markdown

2 small cleanups:

Replace fmt.Errorf("%w", err) with return err where no message is added (driver.go)

and Remove redundant string() cast in fmt.Errorf since %s already handles []byte (main.go)

@mesutoezdil

Copy link
Copy Markdown
Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 8, 2026
@k8s-ci-robot k8s-ci-robot requested a review from tariq1890 June 8, 2026 20:29
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mesutoezdil
Once this PR has been reviewed and has the lgtm label, please assign dims for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @mesutoezdil. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 8, 2026
@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for dra-driver-nvidia-gpu canceled.

Name Link
🔨 Latest commit 0a77a92
🔍 Latest deploy log https://app.netlify.com/projects/dra-driver-nvidia-gpu/deploys/6a27263533060400082adea3

1 similar comment
@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for dra-driver-nvidia-gpu canceled.

Name Link
🔨 Latest commit 0a77a92
🔍 Latest deploy log https://app.netlify.com/projects/dra-driver-nvidia-gpu/deploys/6a27263533060400082adea3

@tariq1890

Copy link
Copy Markdown
Contributor

/ok-to-test
/hold
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: f2cfe46c21012b119edb23f04bcc96d3bb587679

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@mesutoezdil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dra-driver-nvidia-gpu-e2e-lambda-gpu 0a77a92 link false /test pull-dra-driver-nvidia-gpu-e2e-lambda-gpu
pull-dra-driver-nvidia-gpu-e2e-lambda-gpu-gh200 0a77a92 link false /test pull-dra-driver-nvidia-gpu-e2e-lambda-gpu-gh200

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tariq1890

Copy link
Copy Markdown
Contributor

/assign @shivamerla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

4 participants