Skip to content

use %w for error wrapping#1179

Open
mesutoezdil wants to merge 2 commits into
kubernetes-sigs:mainfrom
mesutoezdil:fix-error-wrapping
Open

use %w for error wrapping#1179
mesutoezdil wants to merge 2 commits into
kubernetes-sigs:mainfrom
mesutoezdil:fix-error-wrapping

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jun 8, 2026

Copy link
Copy Markdown

Replace %v with %w in fmt.Errorf calls to allow error unwrapping via errors.Is and errors.As.

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 8, 2026
@mesutoezdil

Copy link
Copy Markdown
Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot requested a review from dims June 8, 2026 20:06
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mesutoezdil
Once this PR has been reviewed and has the lgtm label, please assign varunrsekar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from varunrsekar June 8, 2026 20:06
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @mesutoezdil. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 8, 2026
@mesutoezdil

Copy link
Copy Markdown
Author
Screenshot 2026-06-08 at 22 17 58

i v tested, it works

@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for dra-driver-nvidia-gpu canceled.

Name Link
🔨 Latest commit fa1a5fa
🔍 Latest deploy log https://app.netlify.com/projects/dra-driver-nvidia-gpu/deploys/6a2720ce53b9780008819fcb

@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for dra-driver-nvidia-gpu canceled.

Name Link
🔨 Latest commit c7177ef
🔍 Latest deploy log https://app.netlify.com/projects/dra-driver-nvidia-gpu/deploys/6a27bf8afa4c5c0008bb2f83

Comment thread cmd/compute-domain-kubelet-plugin/root.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants