Skip to content

Set a custom User-Agent on STS token verification requests - #1084

Open
liwadman wants to merge 1 commit into
kubernetes-sigs:masterfrom
liwadman:add-sts-verifier-user-agent
Open

Set a custom User-Agent on STS token verification requests#1084
liwadman wants to merge 1 commit into
kubernetes-sigs:masterfrom
liwadman:add-sts-verifier-user-agent

Conversation

@liwadman

@liwadman liwadman commented Jul 15, 2026

Copy link
Copy Markdown

What this PR does / why we need it:

This PR has the authenticator server set a custom user agent when communicating to AWS STS, to make it a bit easier at a glance to understand if a given GetCallerIdentity request originates from an EKS cluster control plane.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
No issue addressed by this.

@liwadman
Set a custom User-Agent on STS token verification requests
c790af9 
The token verifier validates pre-signed sts:GetCallerIdentity URLs by
issuing a raw HTTP GET with the default net/http client, which sends
"Go-http-client/1.1" as the User-Agent. Identify these requests as
coming from aws-iam-authenticator by setting a User-Agent of
"aws-iam-authenticator/<version>", using the build-time version.
@kubernetes-prow

kubernetes-prow Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liwadman
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: liwadman / name: liwadman (c790af9)

@kubernetes-prow

kubernetes-prow Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Welcome @liwadman!

It looks like this is your first PR to kubernetes-sigs/aws-iam-authenticator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-iam-authenticator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 15, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Hi @liwadman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 15, 2026
@micahhausler

micahhausler commented Aug 4, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2026
@liwadman

liwadman commented Aug 5, 2026

Copy link
Copy Markdown
Author

The single finding from govulncheck exists outside of our PR. I believe the should be implemented the fix in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micahhausler micahhausler Awaiting requested review from micahhausler
@ronaldngounou ronaldngounou Awaiting requested review from ronaldngounou

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liwadman @micahhausler