Skip to content

feat: add STSPresignClient field to GetTokenOptions for custom credential injection - #1063

Open
jitinchekka2 wants to merge 1 commit into
kubernetes-sigs:masterfrom
jitinchekka2:jitin
Open

feat: add STSPresignClient field to GetTokenOptions for custom credential injection#1063
jitinchekka2 wants to merge 1 commit into
kubernetes-sigs:masterfrom
jitinchekka2:jitin

Conversation

@jitinchekka2

Copy link
Copy Markdown

What this PR does / why we need it:

GetWithOptions calls config.LoadDefaultConfig internally, which builds its own AWS config from the environment. There is no way to pass a pre-configured STS client, so callers who have already built credentials (e.g. named profiles, cross-account role chains, or custom endpoints) are forced to re-implement the token presigning logic
themselves rather than using this library.

This pull request adds an optional STSPresignClient STSPresignAPI field to GetTokenOptions. When set, GetWithOptions uses it directly and skips LoadDefaultConfig entirely. When nil, existing behavior is unchanged.

The STSPresignAPI interface is narrow — a single PresignGetCallerIdentity method — and is satisfied by *sts.PresignClient without any adapter.

The presigning logic is extracted from GetWithSTS into a private presignToken helper shared by both paths, so there is no duplication.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 17, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: jitinchekka2 / name: jitinchekka2 (9c54761)

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @jitinchekka2!

It looks like this is your first PR to kubernetes-sigs/aws-iam-authenticator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-iam-authenticator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @jitinchekka2. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jitinchekka2
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 17, 2026
@jitinchekka2

Copy link
Copy Markdown
Author

@hakuna-matatah @ronaldngounou Please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants