Pass volume limit from DescribeInstanceTypes via metadata-labeler#2915
Open
ConnorJC3 wants to merge 1 commit intokubernetes-sigs:masterfrom
Open
Pass volume limit from DescribeInstanceTypes via metadata-labeler#2915ConnorJC3 wants to merge 1 commit intokubernetes-sigs:masterfrom
ConnorJC3 wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
Signed-off-by: Connor Catlett <conncatl@amazon.com>
k8s-ci-robot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XL
ConnorJC3
commented
Apr 8, 2026
|
|
||
| // getMetadata calls the EC2 API to get the number of ENIs and non-CSI managed volumes attached to each node. | ||
| func getMetadata(ctx context.Context, cloud cloud.Cloud, nodes *v1.NodeList, pvInformer cache.SharedIndexInformer) (map[string]enisVolumes, error) { | ||
| func getMetadata(ctx context.Context, c cloud.Cloud, nodes *v1.NodeList, pvInformer cache.SharedIndexInformer) (map[string]enisVolumes, error) { |
Contributor
Author
There was a problem hiding this comment.
We needed to rename because the cloud variable was shadowing the cloud package, thus preventing access to cloud.InstanceTypeInfo
Contributor
Author
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Code Coverage Diff
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
Instead of using our hardcoded table, in the
metadata-labelerpath we now call DIT at runtime and pass the result via node label. This enables users to immediately get updates from EC2 (e.g. new instance releases) without having to wait on a driver release.How was this change tested?
Manually (Create a cluster with
metadata-labelerenabled, observe labels are added) and with new unit tests and modification to the E2E test for metadata-labeler.Does this PR introduce a user-facing change?