fix(operator): guard against nil trainer PodSet in JAX EnforceMLPolicy#3563
Open
immanuwell wants to merge 1 commit into
Open
fix(operator): guard against nil trainer PodSet in JAX EnforceMLPolicy#3563immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Immanuel Tikhonov <pchpr.00@list.ru> Signed-off-by: immanuwell <pchpr.00@list.ru>
fcbfac1 to
a8d9318
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
EnforceMLPolicyin the JAX plugin callsinfo.FindPodSetByAncestor(constants.AncestorTrainer)which returns*PodSetand can benilif no replicatedJob carries thetrainerancestor label. The next line dereferences it directly (trainerPS.Count != nil), causing a nil pointer dereference panic at runtime.The fix adds a
trainerPS != nilguard, matching the pattern already used in the Torch plugin. The XGBoost plugin uses a similar early-return guard too -- the JAX plugin was just missing it.Reproduce:
Create a
ClusterTrainingRuntimewith JAXmlPolicybut without a replicatedJob labeledtrainer.kubeflow.org/trainjob-ancestor-step: trainer, then submit aTrainJobagainst it. The controller panics when processingEnforceMLPolicy.Or run the new unit test case
no panic when JAX policy is set but trainer PodSet is absentafter reverting the one-line fix -- it will panic.Which issue(s) this PR fixes:
Fixes #