Skip to content

feat: add Flux integration and e2e tests#3561

Open
Amir380-A wants to merge 3 commits into
kubeflow:masterfrom
Amir380-A:test/flux-integration-e2e
Open

feat: add Flux integration and e2e tests#3561
Amir380-A wants to merge 3 commits into
kubeflow:masterfrom
Amir380-A:test/flux-integration-e2e

Conversation

@Amir380-A
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Added Integration and E2E tests for Flux

Which issue(s) this PR fixes
Fixes #3256

Copilot AI review requested due to automatic review settings May 29, 2026 11:11
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign electronic-waste for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Copy Markdown

🎉 Welcome to the Kubeflow Trainer! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
  • Our team will review your PR soon! cc @kubeflow/kubeflow-trainer-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

@Amir380-A Amir380-A changed the title Add flux integration and e2e tests add flux integration and e2e tests May 29, 2026
@Amir380-A Amir380-A changed the title add flux integration and e2e tests fix add flux integration and e2e tests May 29, 2026
@Amir380-A Amir380-A changed the title fix add flux integration and e2e tests feat: add Flux integration and e2e tests May 29, 2026
Copy link
Copy Markdown
Contributor

@Sridhar1030 Sridhar1030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work filling in the Flux test coverage gap — tests are passing and the structure looks solid. Had a few questions while reading through:


1. Integration test assertion style — any reason not to use MakeJobSetWrapper?

The MPI integration test builds an expected JobSet with MakeJobSetWrapper and compares the whole object via BeComparableTo. The Flux test fetches the JobSet and checks individual fields with manual for i := range loops. Both work, but the manual approach won't catch unexpected extra fields/containers sneaking in.

Was there a reason the wrapper approach didn't fit here, or would it be worth aligning with the MPI pattern?


2. What are the 3 replicated jobs?

g.Expect(jobSet.Spec.ReplicatedJobs).Should(gomega.HaveLen(3))

Only the node job is inspected after this. Could you add a quick comment noting what the other 2 are? Helps future readers understand what's expected.


3. Suspend/resume flow — intentionally skipped?

The MPI Complete/Failed condition tests verify the Suspended=TrueSuspended=False transition before checking completion. The Flux condition tests go straight from unsuspend to completion without checking the intermediate suspended state. Was that a deliberate simplification, or worth adding for parity?


4. PR title: feat:test:?

Since this only adds tests and a test helper with no production code changes, should the title be test: add Flux integration and e2e tests per Conventional Commits?


Overall this looks good — just wanted to flag these before it goes further. Thanks for picking up #3256!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Testing] Integration and E2E tests for Flux Framework

2 participants