Skip to content

Update kotlinter#5682

Open
Bruce Hamilton (bjhham) wants to merge 1 commit into
release/3.xfrom
bjhham/kotlinter
Open

Update kotlinter#5682
Bruce Hamilton (bjhham) wants to merge 1 commit into
release/3.xfrom
bjhham/kotlinter

Conversation

@bjhham

Copy link
Copy Markdown
Contributor

New default rules introduced in recent updates. I figured it's a good opportunity to pad my LoC changes stats 😏

I'll merge release to main after this to avoid extreme conflicts.

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 180 files, which is 30 over the limit of 150.

To get a review, narrow the scope:
• coderabbit review --type committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b350cb34-aa6e-444a-a8b2-fe2d1e19a76d

📥 Commits

Reviewing files that changed from the base of the PR and between e432907 and 90cf1ab.

📒 Files selected for processing (180)
  • gradle/libs.versions.toml
  • ktor-client/ktor-client-android/jvm/src/io/ktor/client/engine/android/AndroidClientEngine.kt
  • ktor-client/ktor-client-apache/jvm/src/io/ktor/client/engine/apache/ApacheRequestProducer.kt
  • ktor-client/ktor-client-apache5/jvm/src/io/ktor/client/engine/apache5/ApacheRequestProducer.kt
  • ktor-client/ktor-client-cio/common/src/io/ktor/client/engine/cio/CIOEngine.kt
  • ktor-client/ktor-client-cio/common/src/io/ktor/client/engine/cio/Endpoint.kt
  • ktor-client/ktor-client-cio/jvm/test/io/ktor/client/engine/cio/CIOSpecificHttpsTest.kt
  • ktor-client/ktor-client-core/common/src/io/ktor/client/content/ObservableContent.kt
  • ktor-client/ktor-client-core/common/src/io/ktor/client/plugins/DefaultTransform.kt
  • ktor-client/ktor-client-core/common/src/io/ktor/client/plugins/HttpRedirect.kt
  • ktor-client/ktor-client-core/common/src/io/ktor/client/plugins/cache/HttpCache.kt
  • ktor-client/ktor-client-core/common/src/io/ktor/client/plugins/sse/DefaultClientSSESession.kt
  • ktor-client/ktor-client-core/common/src/io/ktor/client/request/RequestBody.kt
  • ktor-client/ktor-client-core/common/src/io/ktor/client/request/forms/FormDataContent.kt
  • ktor-client/ktor-client-core/common/src/io/ktor/client/request/forms/formDsl.kt
  • ktor-client/ktor-client-core/common/src/io/ktor/client/utils/Content.kt
  • ktor-client/ktor-client-core/js/src/io/ktor/client/engine/js/JsClientEngine.kt
  • ktor-client/ktor-client-core/js/src/io/ktor/client/engine/js/compatibility/Utils.kt
  • ktor-client/ktor-client-core/js/src/io/ktor/client/plugins/websocket/JsWebSocketSession.kt
  • ktor-client/ktor-client-core/js/src/io/ktor/client/utils/JsUtils.js.kt
  • ktor-client/ktor-client-core/jvm/src/io/ktor/client/plugins/DefaultTransformersJvm.kt
  • ktor-client/ktor-client-core/nonJvm/src/io/ktor/client/engine/Loader.kt
  • ktor-client/ktor-client-core/posix/src/io/ktor/client/engine/ProxyConfigNative.kt
  • ktor-client/ktor-client-core/wasmJs/src/io/ktor/client/engine/js/JsUtils.kt
  • ktor-client/ktor-client-core/wasmJs/src/io/ktor/client/engine/js/WasmJsClientEngine.kt
  • ktor-client/ktor-client-core/wasmJs/src/io/ktor/client/engine/js/compatibility/Utils.kt
  • ktor-client/ktor-client-curl/desktop/src/io/ktor/client/engine/curl/CurlProcessor.kt
  • ktor-client/ktor-client-curl/desktop/src/io/ktor/client/engine/curl/internal/CurlAdapters.kt
  • ktor-client/ktor-client-curl/desktop/src/io/ktor/client/engine/curl/internal/CurlRaw.kt
  • ktor-client/ktor-client-curl/desktop/src/io/ktor/client/engine/curl/internal/CurlWebSocketSession.kt
  • ktor-client/ktor-client-darwin-legacy/darwin/src/io/ktor/client/engine/darwin/ProxySupportLegacyCommon.kt
  • ktor-client/ktor-client-darwin-legacy/darwin/src/io/ktor/client/engine/darwin/certificates/LegacyCertificatePinner.kt
  • ktor-client/ktor-client-darwin-legacy/darwin/src/io/ktor/client/engine/darwin/internal/legacy/DarwinLegacyUrlUtils.kt
  • ktor-client/ktor-client-darwin-legacy/darwin/src/io/ktor/client/engine/darwin/internal/legacy/DarwinLegacyUtils.kt
  • ktor-client/ktor-client-darwin/darwin/src/io/ktor/client/engine/darwin/internal/DarwinUrlUtils.kt
  • ktor-client/ktor-client-darwin/darwin/src/io/ktor/client/engine/darwin/internal/DarwinWebsocketSession.kt
  • ktor-client/ktor-client-java/jvm/src/io/ktor/client/engine/java/JavaHttpRequest.kt
  • ktor-client/ktor-client-java/jvm/src/io/ktor/client/engine/java/JavaHttpWebSocket.kt
  • ktor-client/ktor-client-jetty-jakarta/jvm/src/io/ktor/client/engine/jetty/jakarta/JettyHttpRequest.kt
  • ktor-client/ktor-client-jetty-jakarta/jvm/src/io/ktor/client/engine/jetty/jakarta/JettyResponseListener.kt
  • ktor-client/ktor-client-jetty/jvm/src/io/ktor/client/engine/jetty/JettyHttpRequest.kt
  • ktor-client/ktor-client-jetty/jvm/src/io/ktor/client/engine/jetty/JettyResponseListener.kt
  • ktor-client/ktor-client-mock/common/src/io/ktor/client/engine/mock/MockUtils.kt
  • ktor-client/ktor-client-okhttp/jvm/src/io/ktor/client/engine/okhttp/OkHttpEngine.kt
  • ktor-client/ktor-client-okhttp/jvm/src/io/ktor/client/engine/okhttp/OkHttpWebsocketSession.kt
  • ktor-client/ktor-client-okhttp/jvm/src/io/ktor/client/engine/okhttp/OkUtils.kt
  • ktor-client/ktor-client-plugins/ktor-client-json/ktor-client-serialization/common/src/io/ktor/client/plugins/kotlinx/serializer/KotlinxSerializer.kt
  • ktor-client/ktor-client-plugins/ktor-client-logging/common/src/io/ktor/client/plugins/logging/Logging.kt
  • ktor-client/ktor-client-plugins/ktor-client-logging/common/src/io/ktor/client/plugins/logging/ObservingUtils.kt
  • ktor-client/ktor-client-plugins/ktor-client-logging/jvm/test/io/ktor/client/plugins/logging/LogBodyFilterTest.kt
  • ktor-client/ktor-client-tests/common/src/io/ktor/client/tests/utils/Generators.kt
  • ktor-client/ktor-client-tests/common/test/io/ktor/client/tests/ContentEncodingIntegrationTest.kt
  • ktor-client/ktor-client-tests/common/test/io/ktor/client/tests/HttpRequestRetryTest.kt
  • ktor-client/ktor-client-tests/common/test/io/ktor/client/tests/MultiPartFormDataTest.kt
  • ktor-client/ktor-client-tests/common/test/io/ktor/client/tests/utils/HttpClient.kt
  • ktor-client/ktor-client-tests/common/test/io/ktor/client/tests/utils/LogMatcher.kt
  • ktor-client/ktor-client-tests/jvm/test/io/ktor/client/tests/CookiesAndRedirectMockedTest.kt
  • ktor-client/ktor-client-webrtc/android/src/io/ktor/client/webrtc/DataChannel.kt
  • ktor-client/ktor-client-webrtc/ios/src/io/ktor/client/webrtc/DataChannel.kt
  • ktor-client/ktor-client-webrtc/ios/src/io/ktor/client/webrtc/Senders.kt
  • ktor-client/ktor-client-winhttp/windows/src/io/ktor/client/engine/winhttp/internal/WinHttpRequestProducer.kt
  • ktor-http/common/src/io/ktor/http/CacheControl.kt
  • ktor-http/common/src/io/ktor/http/Codecs.kt
  • ktor-http/common/src/io/ktor/http/Cookie.kt
  • ktor-http/common/src/io/ktor/http/CookieUtils.kt
  • ktor-http/common/src/io/ktor/http/HeaderValueWithParameters.kt
  • ktor-http/common/src/io/ktor/http/Parameters.kt
  • ktor-http/common/src/io/ktor/http/Query.kt
  • ktor-http/common/src/io/ktor/http/Ranges.kt
  • ktor-http/common/src/io/ktor/http/URLParser.kt
  • ktor-http/common/src/io/ktor/http/auth/HttpAuthHeader.kt
  • ktor-http/common/src/io/ktor/http/content/CompressedContent.kt
  • ktor-http/common/src/io/ktor/http/parsing/Debug.kt
  • ktor-http/common/src/io/ktor/http/parsing/regex/RegexParserGenerator.kt
  • ktor-http/ktor-http-cio/common/src/io/ktor/http/cio/CIOMultipartDataBase.kt
  • ktor-http/ktor-http-cio/common/src/io/ktor/http/cio/ChunkedTransferEncoding.kt
  • ktor-http/ktor-http-cio/common/src/io/ktor/http/cio/ConnectionOptions.kt
  • ktor-http/ktor-http-cio/common/src/io/ktor/http/cio/Multipart.kt
  • ktor-io/common/src/io/ktor/utils/io/ByteChannelScanner.kt
  • ktor-io/common/src/io/ktor/utils/io/ByteReadChannelOperations.kt
  • ktor-io/common/src/io/ktor/utils/io/core/Strings.kt
  • ktor-io/js/src/io/ktor/utils/io/charsets/Charset.js.kt
  • ktor-io/posix/src/io/ktor/utils/io/errors/PosixErrors.kt
  • ktor-network/common/src/io/ktor/network/sockets/SocketBase.kt
  • ktor-network/jvm/src/io/ktor/network/sockets/ConnectUtilsJvm.kt
  • ktor-network/jvmAndPosix/test/io/ktor/network/sockets/tests/UDPSocketTest.kt
  • ktor-network/ktor-network-tls/jvm/src/io/ktor/network/tls/Parser.kt
  • ktor-network/ktor-network-tls/jvm/src/io/ktor/network/tls/TLSClientHandshake.kt
  • ktor-network/ktor-network-tls/jvm/src/io/ktor/network/tls/TLSClientSessionJvm.kt
  • ktor-network/ktor-network-tls/jvm/src/io/ktor/network/tls/TLSHandshakeType.kt
  • ktor-network/ktor-network-tls/ktor-network-tls-certificates/jvm/src/io/ktor/network/tls/certificates/Certificates.kt
  • ktor-network/nonJvm/src/io/ktor/network/sockets/SocketAddress.nonJvm.kt
  • ktor-network/posix/src/io/ktor/network/sockets/CIOReader.kt
  • ktor-network/posix/src/io/ktor/network/sockets/CIOWriter.kt
  • ktor-network/posix/src/io/ktor/network/sockets/DatagramSendChannel.kt
  • ktor-network/posix/src/io/ktor/network/sockets/DatagramSocketNative.kt
  • ktor-network/posix/src/io/ktor/network/sockets/TCPServerSocketNative.kt
  • ktor-network/posix/src/io/ktor/network/sockets/TCPSocketNative.kt
  • ktor-server/ktor-server-config-yaml/jvmAndPosix/src/io/ktor/server/config/yaml/YamlConfig.kt
  • ktor-server/ktor-server-core/common/src/io/ktor/server/config/MapApplicationConfig.kt
  • ktor-server/ktor-server-core/common/src/io/ktor/server/engine/BaseApplicationResponse.kt
  • ktor-server/ktor-server-core/common/src/io/ktor/server/engine/DefaultEnginePipeline.kt
  • ktor-server/ktor-server-core/common/src/io/ktor/server/engine/DefaultTransform.kt
  • ktor-server/ktor-server-core/common/src/io/ktor/server/http/content/DefaultTransform.kt
  • ktor-server/ktor-server-core/common/src/io/ktor/server/routing/RoutePathFormat.kt
  • ktor-server/ktor-server-core/common/src/io/ktor/server/routing/RouteSelector.kt
  • ktor-server/ktor-server-core/common/src/io/ktor/server/routing/RoutingBuilder.kt
  • ktor-server/ktor-server-core/common/src/io/ktor/server/routing/RoutingPath.kt
  • ktor-server/ktor-server-core/common/src/io/ktor/server/routing/RoutingRoot.kt
  • ktor-server/ktor-server-core/jvm/src/io/ktor/server/config/HoconApplicationConfig.kt
  • ktor-server/ktor-server-core/jvm/src/io/ktor/server/config/HoconDecoder.kt
  • ktor-server/ktor-server-core/jvm/src/io/ktor/server/engine/EngineConnectorConfigJvm.kt
  • ktor-server/ktor-server-core/jvm/src/io/ktor/server/engine/internal/CallableUtils.kt
  • ktor-server/ktor-server-core/jvm/src/io/ktor/server/http/content/DefaultTransformJvm.kt
  • ktor-server/ktor-server-core/jvm/src/io/ktor/server/http/content/StaticContent.kt
  • ktor-server/ktor-server-jetty-jakarta/jvm/src/io/ktor/server/jetty/jakarta/JettyApplicationCall.kt
  • ktor-server/ktor-server-jetty-jakarta/jvm/src/io/ktor/server/jetty/jakarta/JettyRequestBodyReader.kt
  • ktor-server/ktor-server-jetty-jakarta/jvm/src/io/ktor/server/jetty/jakarta/JettyWebsocketConnection.kt
  • ktor-server/ktor-server-jetty-jakarta/jvm/src/io/ktor/server/jetty/jakarta/ServerInitializer.kt
  • ktor-server/ktor-server-jetty/jvm/src/io/ktor/server/jetty/ServerInitializer.kt
  • ktor-server/ktor-server-netty/jvm/src/io/ktor/server/netty/NettyApplicationResponse.kt
  • ktor-server/ktor-server-netty/jvm/src/io/ktor/server/netty/cio/RequestBodyHandler.kt
  • ktor-server/ktor-server-netty/jvm/src/io/ktor/server/netty/http1/NettyHttp1Handler.kt
  • ktor-server/ktor-server-netty/jvm/src/io/ktor/server/netty/http2/NettyHttp2Handler.kt
  • ktor-server/ktor-server-netty/jvm/test/io/ktor/tests/server/netty/NettyEngineTest.kt
  • ktor-server/ktor-server-plugins/ktor-server-auth-jwt/jvm/src/io/ktor/server/auth/jwt/JWTUtils.kt
  • ktor-server/ktor-server-plugins/ktor-server-auth-ldap/jvm/src/io/ktor/server/auth/ldap/Ldap.kt
  • ktor-server/ktor-server-plugins/ktor-server-auth/common/src/io/ktor/server/auth/BasicAuth.kt
  • ktor-server/ktor-server-plugins/ktor-server-auth/common/src/io/ktor/server/auth/OAuth2.kt
  • ktor-server/ktor-server-plugins/ktor-server-auth/common/src/io/ktor/server/auth/OAuthProcedure.kt
  • ktor-server/ktor-server-plugins/ktor-server-call-logging/jvm/src/io/ktor/server/plugins/calllogging/CallLoggingConfig.kt
  • ktor-server/ktor-server-plugins/ktor-server-content-negotiation/jvm/test/ContentNegotiationJvmTest.kt
  • ktor-server/ktor-server-plugins/ktor-server-cors/common/src/io/ktor/server/plugins/cors/CORS.kt
  • ktor-server/ktor-server-plugins/ktor-server-cors/common/src/io/ktor/server/plugins/cors/CORSUtils.kt
  • ktor-server/ktor-server-plugins/ktor-server-di/common/src/io/ktor/server/plugins/di/DependencyConflictPolicy.kt
  • ktor-server/ktor-server-plugins/ktor-server-di/common/src/io/ktor/server/plugins/di/DependencyInjection.kt
  • ktor-server/ktor-server-plugins/ktor-server-di/common/src/io/ktor/server/plugins/di/DependencyKeyCovariance.kt
  • ktor-server/ktor-server-plugins/ktor-server-di/common/src/io/ktor/server/plugins/di/DependencyProvider.kt
  • ktor-server/ktor-server-plugins/ktor-server-di/jvm/src/io/ktor/server/plugins/di/DependencyReflectionJvm.kt
  • ktor-server/ktor-server-plugins/ktor-server-di/jvm/src/io/ktor/server/plugins/di/utils/ClasspathReference.jvm.kt
  • ktor-server/ktor-server-plugins/ktor-server-di/jvm/src/io/ktor/server/plugins/di/utils/Types.jvm.kt
  • ktor-server/ktor-server-plugins/ktor-server-partial-content/common/src/io/ktor/server/plugins/partialcontent/PartialContentUtils.kt
  • ktor-server/ktor-server-plugins/ktor-server-routing-openapi/common/src/io/ktor/server/routing/openapi/OperationMapping.kt
  • ktor-server/ktor-server-plugins/ktor-server-routing-openapi/jvm/src/io/ktor/server/routing/openapi/SecuritySchemeAnnotation.jvm.kt
  • ktor-server/ktor-server-plugins/ktor-server-sessions/common/src/io/ktor/server/sessions/serialization/SessionsBackwardCompatibleDecoder.kt
  • ktor-server/ktor-server-plugins/ktor-server-sessions/common/src/io/ktor/server/sessions/serialization/SessionsBackwardCompatibleEncoder.kt
  • ktor-server/ktor-server-plugins/ktor-server-sessions/jvm/src/io/ktor/server/sessions/SessionSerializerReflection.kt
  • ktor-server/ktor-server-servlet-jakarta/jvm/src/io/ktor/server/servlet/jakarta/ServletReader.kt
  • ktor-server/ktor-server-servlet-jakarta/jvm/src/io/ktor/server/servlet/jakarta/ServletUpgrade.kt
  • ktor-server/ktor-server-servlet/jvm/src/io/ktor/server/servlet/ServletReader.kt
  • ktor-server/ktor-server-servlet/jvm/src/io/ktor/server/servlet/ServletUpgrade.kt
  • ktor-server/ktor-server-test-base/jvm/src/io/ktor/server/test/base/EngineTestBaseJvm.kt
  • ktor-server/ktor-server-test-base/jvm/src/io/ktor/server/test/base/HighLoadHttpGenerator.kt
  • ktor-server/ktor-server-test-host/common/src/io/ktor/server/testing/client/TestHttpClientEngine.kt
  • ktor-server/ktor-server-test-suites/common/src/io/ktor/server/testing/suites/WebSocketEngineSuite.kt
  • ktor-server/ktor-server-test-suites/jvm/src/io/ktor/server/testing/suites/ContentTestSuite.kt
  • ktor-server/ktor-server-tests/common/test/io/ktor/tests/server/http/TestEngineMultipartTest.kt
  • ktor-shared/ktor-openapi-schema/common/src/io/ktor/openapi/AdditionalProperties.kt
  • ktor-shared/ktor-openapi-schema/common/src/io/ktor/openapi/DelegateMixinSerializer.kt
  • ktor-shared/ktor-openapi-schema/common/src/io/ktor/openapi/GenericElement.kt
  • ktor-shared/ktor-openapi-schema/common/src/io/ktor/openapi/JsonSchemaInference.kt
  • ktor-shared/ktor-openapi-schema/common/src/io/ktor/openapi/ReferenceOr.kt
  • ktor-shared/ktor-openapi-schema/jvm/src/io/ktor/openapi/YamlSupport.kt
  • ktor-shared/ktor-resources/common/src/io/ktor/resources/UrlBuilder.kt
  • ktor-shared/ktor-serialization/ktor-serialization-kotlinx/common/src/io/ktor/serialization/kotlinx/KotlinxSerializationConverter.kt
  • ktor-shared/ktor-serialization/ktor-serialization-kotlinx/common/src/io/ktor/serialization/kotlinx/KotlinxWebsocketSerializationConverter.kt
  • ktor-shared/ktor-serialization/ktor-serialization-kotlinx/common/src/io/ktor/serialization/kotlinx/SerializerLookup.kt
  • ktor-shared/ktor-serialization/ktor-serialization-kotlinx/ktor-serialization-kotlinx-tests/common/src/AbstractSerializationTest.kt
  • ktor-shared/ktor-test-base/jvm/src/io/ktor/test/junit/ErrorCollector.kt
  • ktor-shared/ktor-websocket-serialization/common/src/io/ktor/websocket/serialization/WebsocketChannelSerialization.kt
  • ktor-shared/ktor-websockets/common/src/io/ktor/websocket/DefaultWebSocketSession.kt
  • ktor-shared/ktor-websockets/common/src/io/ktor/websocket/WebSocketExtension.kt
  • ktor-shared/ktor-websockets/jvm/src/io/ktor/websocket/Serializer.kt
  • ktor-shared/ktor-websockets/jvm/src/io/ktor/websocket/WebSocketReader.kt
  • ktor-shared/ktor-websockets/jvm/src/io/ktor/websocket/WebSocketWriter.kt
  • ktor-utils/common/src/io/ktor/util/HashFunction.kt
  • ktor-utils/common/src/io/ktor/util/converters/ConversionService.kt
  • ktor-utils/common/src/io/ktor/util/date/GMTDateParser.kt
  • ktor-utils/common/src/io/ktor/util/pipeline/SuspendFunctionGun.kt
  • ktor-utils/web/src/io/ktor/util/Crypto.web.kt

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bjhham/kotlinter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bjhham

Copy link
Copy Markdown
Contributor Author

Actually isn't that many changes, just touches a lot of files.

@zibet27

Copy link
Copy Markdown
Collaborator

Actually isn't that many changes, just touches a lot of files.

Which should rerun a lot of tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants