-
Notifications
You must be signed in to change notification settings - Fork 257
fix(live): propagate caller ctx into ResourceGroup inventory ops #4501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jaisheesh-2006
wants to merge
5
commits into
kptdev:main
Choose a base branch
from
Jaisheesh-2006:fix/live-ctx-propagation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
47c2fd0
fix(live): propagate caller ctx into ResourceGroup inventory ops
Jaisheesh-2006 a1199f9
fix(live): propagate caller ctx into ResourceGroup inventory ops
Jaisheesh-2006 e333d2f
fix(live): normalize nil ctx in ClusterClientFactory
Jaisheesh-2006 557b0a9
Docs : Made the doc comments concise
Jaisheesh-2006 d63fb91
Fix : Passed r.ctx into destroyer.Run
Jaisheesh-2006 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // Copyright 2026 The kpt Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package live | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| // TestNewClusterClientFactoryWithContext_NilIsNormalized verifies nil ctx is | ||
| // normalized to Background(). | ||
| func TestNewClusterClientFactoryWithContext_NilIsNormalized(t *testing.T) { | ||
| //nolint:staticcheck // SA1012: deliberately passing nil to exercise the nil-safety guard. | ||
| ccf := NewClusterClientFactoryWithContext(nil) | ||
| require.NotNil(t, ccf, "NewClusterClientFactoryWithContext returned nil") | ||
| require.NotNil(t, ccf.Ctx, "expected nil ctx to be normalized to Background(); got nil") | ||
| // Background() never cancels; Done() returns a nil channel. | ||
| require.Nil(t, ccf.Ctx.Done(), "expected Background()-equivalent ctx; Done() returned non-nil") | ||
| } | ||
|
|
||
| // TestNewClusterClientFactoryWithContext_PreservesRealCtx stores the caller | ||
| // ctx and preserves cancellation. | ||
| func TestNewClusterClientFactoryWithContext_PreservesRealCtx(t *testing.T) { | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| ccf := NewClusterClientFactoryWithContext(ctx) | ||
| require.Same(t, ctx, ccf.Ctx, "factory stored a different ctx than the one passed in") | ||
| assert.NotNil(t, ccf.Ctx.Done(), "ctx should expose Done channel") | ||
| cancel() | ||
| select { | ||
| case <-ccf.Ctx.Done(): | ||
| default: | ||
| require.FailNow(t, "factory ctx did not observe cancellation of the source ctx") | ||
| } | ||
| } | ||
|
|
||
| // TestNewClusterClientFactory_StructLiteralPathTolerated keeps legacy nil ctx. | ||
| func TestNewClusterClientFactory_StructLiteralPathTolerated(t *testing.T) { | ||
| // Exercises the legacy constructor which leaves Ctx unset. | ||
| ccf := NewClusterClientFactory() | ||
| require.Nil(t, ccf.Ctx, "legacy constructor must not synthesize a ctx; callers rely on nil to signal opt-out") | ||
| // We don't call ccf.NewClient here because it needs a real | ||
| // cmdutil.Factory; the observable contract is that inside NewClient | ||
| // the nil Ctx is normalized to Background(). That path is exercised | ||
| // in the existing apply/destroy tests via the CLI integration tests. | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.