add: Calendar and DatePicker components - #725
Open
davedbase wants to merge 6 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
davedbase
marked this pull request as ready for review
August 27, 2026 23:16
jer3m01
requested changes
Aug 28, 2026
jer3m01
left a comment
Member
There was a problem hiding this comment.
Few things to change, will pull the branch to test again after these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three new date/time components to
@kobalte/core, built on@internationalized/datethroughout (never nativeDate), and wires them into the public export surface (packages/core/src/index.tsxhad commented-outCalendar/DatePickerexports left over from a previous attempt — those are now live).DateField— a segmented date/time input (react-spectrum-derived, same lineage as every other Kobalte form component). Supports single/multi-segment editing via keyboard, non-Gregorian calendars viacreateCalendar, granularity control, and the standard form-control system (validationState,required,disabled,readOnly, HTML form integration via a hidden input).Calendar— a date grid supporting single/multiple/range selection, full keyboard navigation, and non-Gregorian calendars. Date math, formatting, and keyboard nav are react-spectrum-derived; range selection follows corvu/calendar's click-only model instead of pointer-drag (first click sets the start, second click commits the end) — credited in the relevant file headers (MIT, Jasmin Noetzli).DatePicker— a trigger button that opens aCalendarinside aPopover. corvu has no dedicated date-picker primitive; this follows its own suggested composition ofCalendardirectly insidePopover, built on Kobalte's own pre-existingPopover/Calendar(not a corvu code port — credited for the pattern only). No segmented text input — the trigger shows the formatted value viaDatePicker.Value.Also included: Solid 2.0
rc.0→rc.3bumpsolid-js/@solidjs/web/@solidjs/signalsbumped to2.0.0-rc.3,babel-preset-solidto2.0.0-rc.2(kept in lockstep across the catalog,overrides, andminimumReleaseAgeExcludeentries inpnpm-workspace.yaml).Shared-primitive fixes surfaced while building this
button-root.tsx/popper-root.tsx: wrapped initialref/placementsignal reads inuntrack()— Solid 2.0's stricter reactivity checks flagged these as untracked reads once exercised by the new components.spin-button-root.tsx: moved{...others}before the named event-handler props to fix a prop-override-order bug (DateField's segment component builds onSpinButton.Root).Docs
.mdxpages for all three components (calendar.mdx,date-field.mdx,date-picker.mdx), matching the existing house style — anatomy, full prop/data-attribute tables, keyboard interaction tables, live previews.2-0-x.mdxwith accurate corvu/react-spectrum attribution.Testing
tsc --noEmitclean,biome checkclean.calendar.test.tsx,create-calendar-state.test.ts,date-field.test.tsx,date-picker.test.tsx).