Fix panel chunk re-split after lazy service clients#3946
Draft
koala73 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
panel-support, while routing static-entry shared code to preloadableapp-sharedTradeoff
app-sharedremains on the static app-shell path and is intentionally preloadablepanel-supportare excluded from HTML modulepreload/static main imports, reclaiming the feat: eliminate barrel file, split panels into variant-based chunks #3113 split without reintroducing the production startup crashValidation
node --test tests/chunk-assignment.test.mjsnpm run typechecknpm run build:fullhttp://127.0.0.1:4173/: HTTP 200, no page errors,hasTdzReferenceError: falsedist/index.htmlno longer modulepreloadspanels-*orpanel-support, and the built main chunk has no staticfrom "./panel-support..."importFixes #3944