Skip to content

feat(feeds): deepen Greek (el) news sources — ERT, AMNA wire, 3 outlets + full server parity#3899

Open
zionappp-ui wants to merge 2 commits into
koala73:mainfrom
zionappp-ui:feat/el-sources
Open

feat(feeds): deepen Greek (el) news sources — ERT, AMNA wire, 3 outlets + full server parity#3899
zionappp-ui wants to merge 2 commits into
koala73:mainfrom
zionappp-ui:feat/el-sources

Conversation

@zionappp-ui
Copy link
Copy Markdown
Contributor

What this adds

Deepens the Greek (`el`) locale with 5 new sources and fixes a critical server/client parity gap — all 5 existing Greek feeds (Kathimerini, Naftemporiki, in.gr, iefimerida, Proto Thema) were present in `src/config/feeds.ts` but entirely absent from `server/worldmonitor/news/v1/_feeds.ts`. This PR adds them all.

New sources (5 feeds, all verified live)

Source Type RSS Items Tier
ERT (public broadcaster) mainstream Google News el 64 1
AMNA (national wire) wire Google News el 100 1
Ta Nea mainstream direct 24 2
Liberal GR mainstream direct 20 2
CNN Greece mainstream direct 22 2

Server parity fix

Kathimerini, Naftemporiki, in.gr, iefimerida, Proto Thema — all added to server digest. Also adds the 3 direct domains (naftemporiki.gr, in.gr, iefimerida.gr) to the vite.config.ts dev-proxy allow-list which was missing them.

ERT (Ellinikí Radiofonía Tileórasi) is Greece's public broadcaster. AMNA (Athens-Macedonian News Agency) is the national wire.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2026

@zionappp-ui is attempting to deploy a commit to the World Monitor Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the trust:caution Brin: contributor trust score caution label May 24, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 24, 2026

Greptile Summary

This PR deepens Greek (el) news coverage by adding 5 new sources (ERT, AMNA, Ta Nea, Liberal GR, CNN Greece) and fixes a server/client parity gap by backfilling the 5 pre-existing Greek feeds into the server digest. It also promotes several Greek sources in tier rankings and adds the three new direct-RSS domains to the Edge Function allowlist.

  • vite.config.ts (broken): Three proxy domains (www.naftemporiki.gr, www.in.gr, www.iefimerida.gr) were accidentally embedded inside BROTLI_EXTENSIONS instead of RSS_PROXY_ALLOWED_DOMAINS, and a missing comma after '.wasm' makes this a hard syntax error — the build will not compile.
  • server/worldmonitor/news/v1/_feeds.ts + src/config/feeds.ts: All 10 Greek feeds are correctly wired with the right URLs and language tags.
  • Allowlists + tier files: api/_rss-allowed-domains.js, shared/rss-allowed-domains.json, and scripts/shared/… counterparts are consistently updated for the three new direct-RSS domains; source-tiers.json tier promotions look reasonable.

Confidence Score: 2/5

Not safe to merge — vite.config.ts has a syntax error that will break the build on any machine that tries to compile it.

The three Greek proxy domains intended for RSS_PROXY_ALLOWED_DOMAINS were accidentally placed inside BROTLI_EXTENSIONS with a missing comma, producing a TypeScript syntax error that prevents the project from building at all. The rest of the feed additions are correct and well-formed.

vite.config.ts lines 14-17 need the three domain strings removed from BROTLI_EXTENSIONS and added to RSS_PROXY_ALLOWED_DOMAINS instead (around line 583).

Important Files Changed

Filename Overview
vite.config.ts Critical syntax error: three proxy domains accidentally injected into BROTLI_EXTENSIONS with a missing comma, breaking the TypeScript build entirely; these were intended for RSS_PROXY_ALLOWED_DOMAINS
server/worldmonitor/news/v1/_feeds.ts Adds 10 Greek (el) feeds covering server parity (5 existing) and 5 new sources; uses gnLocale helper for Google News feeds and direct RSS URLs for others
src/config/feeds.ts Adds 5 new Greek feeds (ERT, AMNA, Ta Nea, Liberal GR, CNN Greece) to the client-side feed config
api/_rss-allowed-domains.js Adds www.tanea.gr, www.liberal.gr, www.cnn.gr to the Vercel Edge Function RSS domain allowlist
shared/rss-allowed-domains.json Mirrors the api/_rss-allowed-domains.js addition of the three new Greek domains (tanea.gr, liberal.gr, cnn.gr)
scripts/shared/source-tiers.json Adds 5 new Greek sources with tiers, promotes in.gr/iefimerida/Proto Thema from tier 3 to 2 and Kathimerini from tier 2 to 1; also converts non-ASCII chars to Unicode escapes in several existing entries
shared/source-tiers.json Identical changes to scripts/shared/source-tiers.json — kept in sync as expected
scripts/shared/rss-allowed-domains.json Identical to shared/rss-allowed-domains.json update — adds tanea.gr, liberal.gr, cnn.gr

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Greek RSS Feed Request] --> B{Feed type?}
    B -- Google News via gnLocale --> C[Kathimerini / Proto Thema / ERT / AMNA]
    B -- Direct RSS --> D[Naftemporiki / in.gr / iefimerida / Ta Nea / Liberal GR / CNN Greece]

    C --> E[server/_feeds.ts Variant Feeds Record]
    D --> E

    E --> F[RSS Proxy vite.config.ts RSS_PROXY_ALLOWED_DOMAINS]
    D --> G{Domain in allowlist?}
    G -- tanea.gr ✅ --> F
    G -- liberal.gr ✅ --> F
    G -- cnn.gr ✅ --> F
    G -- naftemporiki.gr ❌ MISSING --> H[Dev proxy blocked]
    G -- in.gr ❌ MISSING --> H
    G -- iefimerida.gr ❌ MISSING --> H

    subgraph Bug
        I[BROTLI_EXTENSIONS Set lines 14-17]
        J[www.naftemporiki.gr / www.in.gr / www.iefimerida.gr plus syntax error: missing comma]
        I --> J
    end

    H -.->|These ended up here instead| I
Loading

Reviews (1): Last reviewed commit: "feat(feeds): deepen Greek (el) sources —..." | Re-trigger Greptile

Comment thread vite.config.ts Outdated
Comment on lines +14 to +17
const BROTLI_EXTENSIONS = new Set(['.js', '.mjs', '.css', '.html', '.svg', '.json', '.txt', '.xml', '.wasm' 'www.naftemporiki.gr',
'www.in.gr',
'www.iefimerida.gr',
]);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Syntax error: domains injected into wrong Set, missing comma

Three domain strings (www.naftemporiki.gr, www.in.gr, www.iefimerida.gr) were accidentally placed inside BROTLI_EXTENSIONS — a Set of file extensions used for brotli compression — instead of RSS_PROXY_ALLOWED_DOMAINS. Additionally, there is no comma between '.wasm' and 'www.naftemporiki.gr', which is a TypeScript syntax error that will prevent the build from compiling entirely. These domains were intended for RSS_PROXY_ALLOWED_DOMAINS (around line 580), where www.tanea.gr, www.liberal.gr, and www.cnn.gr were correctly added. The fix is to remove these three strings from BROTLI_EXTENSIONS and add them to RSS_PROXY_ALLOWED_DOMAINS instead.

…_ALLOWED_DOMAINS + add missing parity domains + strip Unicode escape noise
@koala73 koala73 added the area: i18n Internationalization, translations label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: i18n Internationalization, translations trust:caution Brin: contributor trust score caution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants