Skip to content

feat(locale): bootstrap Slovenian (sl) locale with i18n + news sources #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zionappp-ui wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(locale): bootstrap Slovenian (sl) locale with i18n + news sources #3888

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f764a3
feat(locale): bootstrap Slovenian (sl) locale with i18n + news sources
zionappp-ui May 24, 2026
c0f335f
fix: correct api allowlist comma, double-comma in LANG_NAMES, i18n.ts…
zionappp-ui May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions api/_rss-allowed-domains.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,4 +324,7 @@ export default [
"feeds.megaphone.fm",
"rss.art19.com",
"idp.nature.com"
"img.rtvslo.si",
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Missing comma after "idp.nature.com" before the new entries. JavaScript arrays require commas between elements — adjacent string literals without a separator is a SyntaxError. This will crash the Edge Function entirely at parse time, making all RSS proxy lookups fail for every locale.

Suggested change
"idp.nature.com"
"img.rtvslo.si",
"idp.nature.com",
"img.rtvslo.si",

"n1info.si",
"www.24ur.com",
];
1 change: 1 addition & 0 deletions public/offline.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ <h1 id="t-title">You're Offline</h1>
nl: { title: "Je bent offline", msg: "World Monitor heeft een internetverbinding nodig voor real-time inlichtingengegevens.", retry: "Opnieuw proberen" },
pl: { title: "Jesteś offline", msg: "World Monitor wymaga połączenia internetowego do otrzymywania danych wywiadowczych w czasie rzeczywistym.", retry: "Ponów próbę" },
pt: { title: "Você está offline", msg: "World Monitor requer uma conexão com a internet para dados de inteligência em tempo real.", retry: "Tentar novamente" },
sl: { title: "Ste brez povezave", msg: "World Monitor zahteva internetno povezavo za podatke o obveščanju v realnem času.", retry: "Poskusi znova" },
ro: { title: "Sunteți Offline", msg: "World Monitor necesită o conexiune la internet pentru date de informații în timp real.", retry: "Încercați din nou" },
ru: { title: "Вы не подключены к интернету", msg: "World Monitor требует подключение к интернету для получения данных разведки в реальном времени.", retry: "Повторить" },
sv: { title: "Du är offline", msg: "World Monitor kräver en internetanslutning för realtidsunderrättelsedata.", retry: "Försök igen" },
Expand Down
5 changes: 4 additions & 1 deletion scripts/shared/rss-allowed-domains.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,5 +320,8 @@
"rss.libsyn.com",
"feeds.megaphone.fm",
"rss.art19.com",
"idp.nature.com"
"idp.nature.com",
"img.rtvslo.si",
"n1info.si",
"www.24ur.com"
]
5 changes: 4 additions & 1 deletion scripts/shared/source-tiers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,5 +262,8 @@
"ArXiv AI": 4,
"AI News": 4,
"Layoffs News": 4,
"GloNewswire (Taiwan)": 4
"GloNewswire (Taiwan)": 4,
"RTV SLO": 1,
"N1 Slovenia": 2,
"24ur": 2
}
2 changes: 1 addition & 1 deletion scripts/sync-offline-translations.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import { readFileSync, writeFileSync } from 'node:fs';
import path from 'node:path';

const LOCALES = ['en', 'ar', 'bg', 'cs', 'de', 'el', 'es', 'fr', 'hu', 'it', 'ja', 'ko', 'nl', 'pl', 'pt', 'ro', 'ru', 'sv', 'th', 'tr', 'vi', 'zh'];
const LOCALES = ['en', 'ar', 'bg', 'cs', 'de', 'el', 'es', 'fr', 'hu', 'it', 'ja', 'ko', 'nl', 'pl', 'pt', 'ro', 'ru', 'sl', 'sv', 'th', 'tr', 'vi', 'zh'];
const OFFLINE_HTML = 'public/offline.html';
const LOCALES_DIR = 'src/locales';

Expand Down
4 changes: 2 additions & 2 deletions scripts/translate-locales.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ const onlyArg = [...args].find(a => a.startsWith('--only='));
const onlyLocales = onlyArg ? onlyArg.slice('--only='.length).split(',') : null;

const ROOT = proTest ? 'pro-test/src/locales' : 'src/locales';
const LOCALES = ['ar', 'bg', 'cs', 'de', 'el', 'es', 'fr', 'hu', 'it', 'ja', 'ko', 'nl', 'pl', 'pt', 'ro', 'ru', 'sv', 'th', 'tr', 'vi', 'zh'];
const LOCALES = ['ar', 'bg', 'cs', 'de', 'el', 'es', 'fr', 'hu', 'it', 'ja', 'ko', 'nl', 'pl', 'pt', 'ro', 'ru', 'sl', 'sv', 'th', 'tr', 'vi', 'zh'];
const LANG_NAMES = {
ar: 'Arabic', bg: 'Bulgarian', cs: 'Czech', de: 'German', el: 'Greek',
es: 'Spanish', fr: 'French', hu: 'Hungarian', it: 'Italian', ja: 'Japanese',
ko: 'Korean', nl: 'Dutch', pl: 'Polish', pt: 'Portuguese (Brazil)',
ro: 'Romanian', ru: 'Russian', sv: 'Swedish', th: 'Thai', tr: 'Turkish',
ro: 'Romanian', ru: 'Russian', sl: 'Slovenian',, sv: 'Swedish', th: 'Thai', tr: 'Turkish',
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Double comma ,, after sl: 'Slovenian' is a SyntaxError in JavaScript. Running scripts/translate-locales.mjs will throw immediately, preventing locale regeneration for any language — including the new sl locale.

Suggested change
ro: 'Romanian', ru: 'Russian', sl: 'Slovenian',, sv: 'Swedish', th: 'Thai', tr: 'Turkish',
ro: 'Romanian', ru: 'Russian', sl: 'Slovenian', sv: 'Swedish', th: 'Thai', tr: 'Turkish',

vi: 'Vietnamese', zh: 'Simplified Chinese',
};
const BATCH_SIZE = 50;
Expand Down
4 changes: 4 additions & 0 deletions server/worldmonitor/news/v1/_feeds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ export const VARIANT_FEEDS: Record<string, Record<string, ServerFeed[]>> = {
{ name: 'Híradó', url: gnLocale('site:hirado.hu when:2d', 'hu', 'HU', 'HU:hu'), lang: 'hu' },
{ name: 'Portfolio.hu', url: 'https://portfolio.hu/rss/all.xml', lang: 'hu' },
{ name: 'ATV', url: 'https://www.atv.hu/rss', lang: 'hu' },
{ name: 'RTV SLO', url: 'https://img.rtvslo.si/feeds/00.xml', lang: 'sl' },
{ name: 'N1 Slovenia', url: 'https://n1info.si/feed/', lang: 'sl' },
{ name: '24ur', url: 'https://www.24ur.com/rss', lang: 'sl' },

],
middleeast: [
{ name: 'BBC Middle East', url: 'https://feeds.bbci.co.uk/news/world/middle_east/rss.xml' },
Expand Down
5 changes: 4 additions & 1 deletion shared/rss-allowed-domains.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,5 +320,8 @@
"rss.libsyn.com",
"feeds.megaphone.fm",
"rss.art19.com",
"idp.nature.com"
"idp.nature.com",
"img.rtvslo.si",
"n1info.si",
"www.24ur.com"
]
5 changes: 4 additions & 1 deletion shared/source-tiers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,5 +262,8 @@
"ArXiv AI": 4,
"AI News": 4,
"Layoffs News": 4,
"GloNewswire (Taiwan)": 4
"GloNewswire (Taiwan)": 4,
"RTV SLO": 1,
"N1 Slovenia": 2,
"24ur": 2
}
5 changes: 5 additions & 0 deletions src/config/feeds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export const SOURCE_TYPES: Record<string, SourceType> = {
'Telex': 'mainstream', 'Index.hu': 'mainstream', 'HVG': 'mainstream',
'444.hu': 'mainstream', '24.hu': 'mainstream', 'Híradó': 'mainstream',
'ATV': 'mainstream', 'Portfolio.hu': 'market',
'RTV SLO': 'mainstream', 'N1 Slovenia': 'mainstream', '24ur': 'mainstream',
'SVT Nyheter': 'mainstream', 'Dagens Nyheter': 'mainstream', 'Svenska Dagbladet': 'mainstream',
// Brazilian Addition
'Brasil Paralelo': 'mainstream',
Expand Down Expand Up @@ -272,6 +273,10 @@ const FULL_FEEDS: Record<string, Feed[]> = {
{ name: 'Híradó', url: rss('https://news.google.com/rss/search?q=site:hirado.hu+when:2d&hl=hu&gl=HU&ceid=HU:hu'), lang: 'hu' },
{ name: 'Portfolio.hu', url: rss('https://portfolio.hu/rss/all.xml'), lang: 'hu' },
{ name: 'ATV', url: rss('https://www.atv.hu/rss'), lang: 'hu' },
{ name: 'RTV SLO', url: rss('https://img.rtvslo.si/feeds/00.xml'), lang: 'sl' },
{ name: 'N1 Slovenia', url: rss('https://n1info.si/feed/'), lang: 'sl' },
{ name: '24ur', url: rss('https://www.24ur.com/rss'), lang: 'sl' },

// Greek (EL)
{ name: 'Kathimerini', url: rss('https://news.google.com/rss/search?q=site:kathimerini.gr+when:2d&hl=el&gl=GR&ceid=GR:el'), lang: 'el' },
{ name: 'Naftemporiki', url: rss('https://www.naftemporiki.gr/feed/'), lang: 'el' },
Expand Down
Loading
Loading