fix: handle invalid Referrer URLs in back() without crashing#1948
Open
guoyangzhen wants to merge 3 commits intokoajs:masterfrom
Open
fix: handle invalid Referrer URLs in back() without crashing#1948guoyangzhen wants to merge 3 commits intokoajs:masterfrom
guoyangzhen wants to merge 3 commits intokoajs:masterfrom
Conversation
Fixes koajs#1746 The origin getter returned this.req.headers.origin (the CORS Origin header) which ignores the proxy flag. Changed to construct origin from protocol and host getters, which already respect X-Forwarded-Proto and X-Forwarded-Host when app.proxy is true.
…id URLs The back() method called new URL(referrer) without error handling. An invalid Referrer header (e.g. '://invalid', malicious input) would throw an uncaught TypeError and crash the request. Now catches the error and falls through to the alt parameter.
Both redirect() and back() called new URL() without error handling. Invalid URL input (malformed, malicious, or incomplete) would throw an uncaught TypeError and crash the request. Changes: - redirect(): wrap new URL(url) in try-catch, fall back to encoding as-is - back(): wrap new URL(referrer) in try-catch, fall back to alt parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both
redirect()andback()callednew URL()without error handling. Invalid URL input (malformed, malicious, or incomplete) would throw an uncaughtTypeErrorand crash the request with a 500 error.redirect()
back()
Impact
Without this fix, a request with
Referrer: ://invalidorLocation: https://crashes the entire request handler.