agentgateway emitter: add service-upstream backend mapping#94
Merged
Conversation
Project ingress-nginx service-upstream annotations into AgentgatewayBackend\nresources and rewrite covered HTTPRoute backendRefs to target those\nbackends. This keeps service-scoped backend protocol policy behavior\nintact while enabling static upstream routing semantics for\nagentgateway output.\n\nAdd an agentgateway integration fixture and golden output for\nservice_upstream, and update emitter/provider documentation to describe\nthe new mapping. Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind test
/kind documentation
What this PR does / why we need it:
Adds Agentgateway emitter support for ingress-nginx
service-upstream.When
nginx.ingress.kubernetes.io/service-upstream: "true"is set, the generated agentgateway output now:AgentgatewayBackendper covered Service backend withspec.static.hostandspec.static.portHTTPRoutebackendRefs to point to thatAgentgatewayBackendThe change keeps existing Service-targeted backend protocol policy projection intact (e.g.
backend-protocol: GRPCstill maps toAgentgatewayPolicy.spec.backend.http.version: HTTP2).It also adds integration test coverage and updates documentation for provider and emitter mappings.
Which issue(s) this PR fixes:
Refs #59
Does this PR introduce a user-facing change?: