Skip to content

Fix phi0 type in PCAInfo, correct omega sign, and add covariance matrix to TrackStates - #79

Merged
BrieucF merged 10 commits into
key4hep:mainfrom
andread3vita:FixPRissues
May 5, 2026
Merged

Fix phi0 type in PCAInfo, correct omega sign, and add covariance matrix to TrackStates#79
BrieucF merged 10 commits into
key4hep:mainfrom
andread3vita:FixPRissues

Conversation

@andread3vita

@andread3vita andread3vita commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

BEGINRELEASENOTES

  • Correct the data type of phi0 when saving it in PCAInfo
  • Correct the sign of omega by properly determining the particle charge during initialization
  • Add covariance matrix to fitted trackStates
  • Fix how filtered tracks are saved in the output file: now for each fitted track there is the corresponding filtered track
  • Expose EDM4Hep units to the user

ENDRELEASENOTES

Hello everyone,

This pull request is opened to address a couple of issues identified in the current reconstruction:

  • correction of the phi0 type when storing it in PCAInfo
  • improvement of the omega sign determination through a correct charge estimation during initialization
  • Implementation of the covariance matrix for fitted trackStates

Thank you!

Andrea

@andread3vita andread3vita changed the title Fix phi0 type in PCAInfo and correct omega sign Fix phi0 type in PCAInfo, correct omega sign, and add covariance matrix to TrackStates Apr 29, 2026
@BrieucF

BrieucF commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Hi Andrea, thanks for this! Is it possible to have the user facing part (i.e. mainly the Gaudi properties) following the EDM4hep conventions?

@BrieucF
BrieucF merged commit 878b4d2 into key4hep:main May 5, 2026
5 checks passed
@BrieucF

BrieucF commented May 5, 2026

Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants