Skip to content

Cleanup k4GaudiPandora, remove untouched files from DDMarlinPandora#6

Closed
jmcarcell wants to merge 1 commit into
mainfrom
cleanup
Closed

Cleanup k4GaudiPandora, remove untouched files from DDMarlinPandora#6
jmcarcell wants to merge 1 commit into
mainfrom
cleanup

Conversation

@jmcarcell

@jmcarcell jmcarcell commented Sep 9, 2024

Copy link
Copy Markdown
Member

BEGINRELEASENOTES

  • Cleanup k4GaudiPandora, remove untouched files from DDMarlinPandora

ENDRELEASENOTES

I think I didn't touch any file that was ported, please check @kkostova16.

@kkostova16

Copy link
Copy Markdown

DDBFieldPlugin.cc can be removed too. I think also DDMCParticleCreator and DDPfoCreator can be removed now and added later when fully ported, since they are not used in DDCaloDigi or DDSimpleMuonDigi.

@jmcarcell

Copy link
Copy Markdown
Member Author

Any objections to this @andresailer? I would rather have the new files appear as new ones since anyway the diff is not going to be readable, and only those that are needed should be here, there is the original repository to keep the Marlin versions.

@andresailer

Copy link
Copy Markdown
Contributor

Please keep them in, also in view of potential conflicts when PRs working on the port need to be rebased.

@andresailer

Copy link
Copy Markdown
Contributor

I think if at all we can revisit after #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants