Skip to content

Disallow setting metadata parameters in the event loop#400

Merged
jmcarcell merged 3 commits into
mainfrom
metadata-loop
Apr 21, 2026
Merged

Disallow setting metadata parameters in the event loop#400
jmcarcell merged 3 commits into
mainfrom
metadata-loop

Conversation

@jmcarcell

Copy link
Copy Markdown
Member

Fix #302

BEGINRELEASENOTES

  • Disallow setting metadata parameters in the event loop
  • Add a test that checks that it is not possible

ENDRELEASENOTES

Create a function since this check is also needed in the put override for edm4hep::utils::ParticleIDMeta.

Comment thread k4FWCore/include/k4FWCore/IMetadataSvc.h
Comment thread k4FWCore/include/k4FWCore/IMetadataSvc.h
@jmcarcell

Copy link
Copy Markdown
Member Author

I'll merge this later today if there aren't any more comments

@jmcarcell jmcarcell merged commit 4c89e08 into main Apr 21, 2026
6 of 7 checks passed
@jmcarcell jmcarcell deleted the metadata-loop branch April 21, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should writing metadata during event loop be allowed for MetadataSvc?

3 participants