build: Add optional in-build ACTS build#67
Open
paulgessinger wants to merge 2 commits into
Open
Conversation
jmcarcell
reviewed
Jun 9, 2026
| # The setup below allows optionally building ACTS directly with the k4ActsTracking build. | ||
| # This avoids having to run separate build and install steps, and also allows getting a | ||
| # combined compilation database out. | ||
| if(IS_DIRECTORY ${ACTS_SOURCE_DIR}) |
Member
|
Are you going to use it? I think people are used to building in two steps. Basically the same could be done with many combinations of 2 or more repositories or externals in Key4hep, but no one has asked to add something like this so far. |
Collaborator
Author
|
I already used it last week to make changes to ACTS so that main becomes non-breaking. If we don't merge this I'll have to maintain a patch. This setup makes it much easier to update k4ActsTracking when ACTS changes and make changes to ACTS and test the impact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES