Add a steering file for using the native EDM4hep algorithms#70
Add a steering file for using the native EDM4hep algorithms#70jmcarcell wants to merge 89 commits into
Conversation
|
Planning on merging this soon @Zehvogel when CI passes and a few minor things are fixed |
Zehvogel
left a comment
There was a problem hiding this comment.
Hi, thanks for this effort!
I am mostly very happy with the results. However, in some cases, like the conformal tracking, I think there is a bit too much chaos in the file. I have left some comments inline.
| ConformalTrackingSequence = [ | ||
| MyConformalTracking, | ||
| ClonesAndSplitTracksFinder, | ||
| clones_and_split_tracks_finder, |
There was a problem hiding this comment.
any reason to rename this one in particular?
There was a problem hiding this comment.
Not really, there is a mix of both. PEP8 says lower case and underscore are preferred so we could have them all be that. The names of the algorithms are CamelCames though. https://peps.python.org/pep-0008/#function-and-variable-names
There was a problem hiding this comment.
I know that Python prefers snake_case, but I just find it odd to rename only one. I would say we keep it in CamelCase for now so that it matches the algorithm names better. :)
BEGINRELEASENOTES
CLDReconstruction_iosvc.py, a steering file that uses IOSvc and the native algorithms when possibleENDRELEASENOTES
Tested that the original marlin reconstruction gives the same results before and after since nothing should have changed for it, both with
--truthTrackingand without (up to some ID changes because I think there is non-deterministic ordering in Refit, but the tracks are the same).