Skip to content

Create bfcp.py#635

Open
amoxuk wants to merge 1 commit into
kbandla:masterfrom
amoxuk:master
Open

Create bfcp.py#635
amoxuk wants to merge 1 commit into
kbandla:masterfrom
amoxuk:master

Conversation

@amoxuk

@amoxuk amoxuk commented Jun 24, 2022

Copy link
Copy Markdown

add bfcp

add bfcp
Comment thread dpkt/bfcp.py
dpkt.Packet.unpack(self, buf)
l_ = []
if self.f:
pass

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unimplemented feature...
The Fragmentation (F) flag

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding this as a comment in code would be helpful

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it.

Comment thread dpkt/bfcp.py
AttrType.PRIORITY):
if AttrType.SUPPORTED_ATTRIBUTES == self.type:
self.value = [d << 1 for d in self.value]
data += struct.pack(f'!{len(self.value)}B', *self.value)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build failed because the f-strings are not supported in older versions of python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants