[Proof of Concept] Using PointNeighbors.jl instead of a vector of bonds#105
Draft
efaulhaber wants to merge 4 commits intokaipartmann:mainfrom
Draft
[Proof of Concept] Using PointNeighbors.jl instead of a vector of bonds#105efaulhaber wants to merge 4 commits intokaipartmann:mainfrom
efaulhaber wants to merge 4 commits intokaipartmann:mainfrom
Conversation
efaulhaber
commented
Jun 10, 2024
efaulhaber
commented
Jun 10, 2024
| storage.b_int .= 0 | ||
| storage.n_active_bonds .= 0 | ||
| for point_id in each_point_idx | ||
| Threads.@threads :static for point_id in each_point_idx |
Author
There was a problem hiding this comment.
I just wanted to ignore the chunks and only have one chunk, over which I run a threaded loop. The performance is probably similar, I just wanted to have more threads and therefore less cache per thread, and this was easier than looking at the chunks stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on trixi-framework/PointNeighbors.jl#10.
There's a small speedup for small problems on my laptop on 1 thread (Apple M2 Pro):
For larger problems, there is a 2x speedup on 64 threads of a Threadripper 3990X:
No speedup on a single thread (maybe due to more cache per thread?):