fix(ci): skip unnecessary waits in Cypress mock server replay mode#13323
Open
venkatakarthikm-maker wants to merge 4 commits into
Open
fix(ci): skip unnecessary waits in Cypress mock server replay mode#13323venkatakarthikm-maker wants to merge 4 commits into
venkatakarthikm-maker wants to merge 4 commits into
Conversation
Changed Files |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13323 +/- ##
=======================================
Coverage ? 0
=======================================
Files ? 0
Lines ? 0
Branches ? 0
=======================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
In mock/replay mode (
CYPRESS_MOCK_SERVER=true), several Cypress specs have hardcodedcy.wait()calls designed to let real-world TTLs expire. Since cassettes are already recorded with the final state, these waits serve no purpose in replay and inflate mock batch CI runtime significantly.Closes #13327
Waits removed in mock mode
00-CoreFlows.cy.js52-ClientSessionValidation.cy.js33-ManualRetry.cy.js40-ExternalVault.cy.js52-AlternativePayments.cy.js~251 seconds saved per connector in mock batches.
Additional Changes
Motivation and Context
Fixes #13327 — mock batch 3 (nmi calida adyen peachpayments payload) was taking 1–1.5 hours partly due to these waits running unnecessarily in replay mode.
How did you test it?
Guards use the existing
isMockServer()helper frommitmProxy.js. Live/mandatory test runs are unaffected — the waits only skip whenCYPRESS_MOCK_SERVER=true.Checklist
cargo +nightly fmt --allcargo clippy