shell: nushell integration scripts by sim590 · Pull Request #4630 · junegunn/fzf

sim590 · 2025-12-09T03:36:58Z

Keybindings alt_c, ctrl_r and ctrl_t
Completion functions:
- base implementation for ** completion
- extra completion functionalities for programs such as:
  - pass
  - ssh, scp, sftp, telnet
  - kill
  - cd, pushd, rmdir

Closes: #4122

Fixes some path issues. There are still some other things to fix

Pass~[1] is a command line password storage utility. Possible queries are deduced from the file GPG hierarchy under ~/.password-store. [1]: https://www.passwordstore.org/

…sure parameter

Not sure why it doesn't work in this context, but if those are not removed, the completion process doesn't substitute the selected value to '**'.

fix typo shell/key-bindinds.nu → shell/key-bindings.nu

Co-authored-by: Junegunn Choi <junegunn.c@gmail.com>

The _nu suffix is unnecessary since these functions are only loaded in nushell. The only exception is __fzf_defaults_nu which keeps its suffix to avoid conflicting with __fzf_defaults in key-bindings.nu.

@junegunn

Rename __fzf_defaults_nu to __fzf_defaults and align the implementation with the identical function in key-bindings.nu, as suggested by @junegunn.

Save the pre-fzf completer in $env.__fzf_previous_completer on first load. On re-source, use that saved reference as the base instead of the current completer (which is already the fzf wrapper), preventing wrapper nesting while still allowing re-sourcing to take effect.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

junegunn · 2026-05-07T08:52:47Z

I'm not a nushell user so I might be missing something, but that the fuzzy completion is not always available is quite confusing to me. vim **<tab> works, ls **<tab> doesn't. kill **<tab> doesn't work, unless I change it to ^kill **<tab>. This is confusing, also a bit frustrating to see that fuzzy completion doesn't pop up only after I typed in **. Is there a way to make the situation better? Or is this a fundamental limitation of nushell?

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

sim590 · 2026-05-07T23:41:37Z

These are fundamental limitations of Nushell's completion architecture:

ls **<TAB> / kill **<TAB> don't work because ls and kill are Nushell built-in commands. Since Nushell 0.103.0 (nushell/nushell#15086), the external completer is no longer invoked for internal commands. Using ^kill **<TAB> forces the external binary, which goes through our completer — that's why it works.
The ** trigger requirement exists because Nushell's external completer is only called "if no Nushell completions were found". For external commands (like vim, ^kill), Nushell has no built-in completions, so our completer gets called and can check for the trigger. The trigger is a deliberate design choice (same as bash/zsh) to avoid replacing the user's existing completions for every command unconditionally.

AFAIK, there's no way around these limitations without changes on the Nushell side.

…ushell Like fish, the nushell block now checks $key_bindings and $auto_completion. When both are enabled, fzf --nushell is used as before. When only one is enabled, the relevant section is extracted from fzf --nushell output via awk, embedding the content directly rather than sourcing from an absolute path.

Rename the generated nushell autoload file to _fzf_integration.nu to reduce the risk of overwriting a user's custom script. Also replace the awk extraction with a direct cp of the relevant source file for the partial key-bindings/completion cases.

junegunn

Thanks for the persistence; it's good to go.

But I'll merge it right before I release a new version so the README doesn't mention unreleased features and confuse users.

junegunn · 2026-05-13T04:47:06Z

Ah, we also need to update

fzf/man/man1/fzf.1

Lines 1352 to 1369 in 263eb47

    
           .SS SHELL INTEGRATION 
        
           .TP 
        
           .B "\-\-bash" 
        
           Print script to set up Bash shell integration 
        
           e.g. \fBeval "$(fzf \-\-bash)"\fR 
        
           .TP 
        
           .B "\-\-zsh" 
        
           Print script to set up Zsh shell integration 
        
           e.g. \fBsource <(fzf \-\-zsh)\fR 
        
           .TP 
        
           .B "\-\-fish" 
        
           Print script to set up Fish shell integration 
        
           e.g. \fBfzf \-\-fish | source\fR

sim590 · 2026-05-13T07:06:49Z

Ah, we also need to update

fzf/man/man1/fzf.1

Lines 1352 to 1369 in 263eb47

.SS SHELL INTEGRATION

.TP

.B "\-\-bash"

Print script to set up Bash shell integration

e.g. \fBeval "$(fzf \-\-bash)"\fR

.TP

.B "\-\-zsh"

Print script to set up Zsh shell integration

e.g. \fBsource <(fzf \-\-zsh)\fR

.TP

.B "\-\-fish"

Print script to set up Fish shell integration

e.g. \fBfzf \-\-fish | source\fR

Did it in 52a23e3

imsys and others added 30 commits May 4, 2025 04:58

A Nushell partial support test

5aa22d4

Some efforts to get it working

79eab96

Almost working

64d5ace

somewhat working

6011574

seems to be working

785bc07

lower case tab

30d1d45

different implementation approach: External Completers

a4ef417

fixes fzf custom height

5236752

Nushell - fzf uses realative path

4b8fef0

nushell - layout reverse

3bd895c

nushell: fixes ssh completion

15314f4

Nushell: refactoring

b2b25b2

Nushell: makes the code of both options similar.

e4ceecb

Fixes some path issues. There are still some other things to fix

removing debug print

3e0d3a8

Nushell: seems to be the final fix for path issues

da97e61

cleanup and kill completion

20bb07c

Nushell: prepend binding instead of appending

c39e328

Nushell: Another alternative implementation, but using nushell menu

bde90bc

Nushell: notes

456cf2a

renames completion.nu to completion-bind.nu

6289a28

Nushell: notes

77d0b56

Nushell: minor grammar/spelling

d1a6120

fix typo

1f66d6e

completion-external: add pass completion

7ec4d98

Pass~[1] is a command line password storage utility. Possible queries are deduced from the file GPG hierarchy under ~/.password-store. [1]: https://www.passwordstore.org/

completion-external: use type "any" for optional closure

95f636f

completion-external: use flag for _fzf_complete_nu's post_process_clo…

e9ac742

…sure parameter

completion-external: remove bad "return" calls

8c2183d

Not sure why it doesn't work in this context, but if those are not removed, the completion process doesn't substitute the selected value to '**'.

completion-external: remove unused input_line_before_trigger parameter

90d2331

completion-external: fix alignement

ef66bd7

Merge pull request #1 from zalewskigrzegorz/fix/nushel-scipt-typo

535ff16

fix typo shell/key-bindinds.nu → shell/key-bindings.nu

junegunn reviewed May 4, 2026

View reviewed changes

Comment thread test/lib/common.rb Outdated

junegunn reviewed May 4, 2026

View reviewed changes

Comment thread shell/key-bindings.nu Outdated

junegunn reviewed May 4, 2026

View reviewed changes

Comment thread shell/completion.nu Outdated

sim590 and others added 8 commits May 4, 2026 12:34

Apply rewording of comment on $env.history from @junegunn

8b4d29c

Co-authored-by: Junegunn Choi <junegunn.c@gmail.com>

fix(completion): use open --raw for FZF_DEFAULT_OPTS_FILE

8632148

fix(completion): harmonize TMUX_PANE check with key-bindings.nu

a96feb6

refactor(completion): remove _nu suffix from function names

76bcb97

The _nu suffix is unnecessary since these functions are only loaded in nushell. The only exception is __fzf_defaults_nu which keeps its suffix to avoid conflicting with __fzf_defaults in key-bindings.nu.

fix(completion): prevent wrapper nesting on re-source

0b1d82e

test: replace sleep with polling for nushell readiness

41af912

fixup! test: replace sleep with polling for nushell readiness

22c1fb1

refactor(completion): harmonize __fzf_defaults with key-bindings.nu

6485735

Rename __fzf_defaults_nu to __fzf_defaults and align the implementation with the identical function in key-bindings.nu, as suggested by @junegunn.

junegunn reviewed May 6, 2026

View reviewed changes

Comment thread shell/completion.nu

sim590 added 2 commits May 6, 2026 12:37

style(completion): fix some code alignment

9c4d392

junegunn requested a review from Copilot May 7, 2026 08:43

Copilot started reviewing on behalf of junegunn May 7, 2026 08:44 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread shell/completion.nu

Comment thread install Outdated

Comment thread .github/workflows/linux.yml

Apply copilot suggestion for /etc/apt/keyrings

bae407b

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

sim590 added 3 commits May 10, 2026 18:18

fix(uninstall): rename fzf.nu to _fzf_integration.nu

37d83c1

junegunn previously approved these changes May 13, 2026

View reviewed changes

docs(man): add --nushell flag to man page

52a23e3

sim590 dismissed junegunn’s stale review via 52a23e3 May 13, 2026 07:05

junegunn approved these changes May 14, 2026

View reviewed changes

Merge branch 'master' into nushell-integration

d25f3da

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

shell: nushell integration scripts#4630

shell: nushell integration scripts#4630
sim590 wants to merge 129 commits into
junegunn:masterfrom
sim590:nushell-integration

sim590 commented Dec 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

junegunn commented May 7, 2026 •

edited

Loading

Uh oh!

sim590 commented May 7, 2026

Uh oh!

junegunn left a comment

Uh oh!

junegunn commented May 13, 2026

Uh oh!

sim590 commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

sim590 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

junegunn commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sim590 commented May 7, 2026

Uh oh!

junegunn left a comment

Choose a reason for hiding this comment

Uh oh!

junegunn commented May 13, 2026

Uh oh!

sim590 commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sim590 commented Dec 9, 2025 •

edited

Loading

junegunn commented May 7, 2026 •

edited

Loading