Fix delpaths with negative array indices in non-leaf positions#3543
Open
eyupcanakman wants to merge 1 commit into
Open
Fix delpaths with negative array indices in non-leaf positions#3543eyupcanakman wants to merge 1 commit into
eyupcanakman wants to merge 1 commit into
Conversation
delpaths resolves a positive and a negative array index against the same element at the leaf level (jv_dels), but the grouping in delpaths_sorted compared path components directly, so a negative index in a non-leaf position was applied as a separate deletion against the array already shortened by the positive one. Resolve negative indices to their positive equivalents at each array level before grouping. Fixes jqlang#3538
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delanddelpathsreconcile a positive and a negative array index that hit the same element when both sit at the leaf of a path. Non-leaf positions are different.delpaths_sortedcompares path components directly, so a negative non-leaf index runs as a separate deletion against the array already shortened by the positive one. On[[0,1,2,3,4,5,6,7,8,9]],del(.[0][-6], .[-1][6])gives[[0,1,2,4,5,7,8,9]]instead of[[0,1,2,3,5,7,8,9]]. Resolve negative indices against the array length at each level before grouping, like the leaf level does.Fixes #3538