test: add concurrent dump/checkPoint stress test for Profiler#716
Merged
ar merged 1 commit intoMay 11, 2026
Merged
Conversation
Add a multi-threaded stress test that verifies Profiler.dump() and Profiler.checkPoint() can be called concurrently without triggering ConcurrentModificationException. The test spawns 4 writer threads (2000 checkpoints each) alongside a single dumper thread (2000 dumps), all starting simultaneously via CountDownLatch to maximize the chance of catching race conditions. Assisted-by: Hermes Agent:qwen36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a multi-threaded stress test that verifies
Profiler.dump()andProfiler.checkPoint()can be called concurrently without triggeringConcurrentModificationException.Test Details
The test spawns 4 writer threads (2000 checkpoints each) alongside a single dumper thread (2000 dumps), all starting simultaneously via
CountDownLatchto maximize the chance of catching race conditions.Test strategy
checkPoint()with unique event names, modifying the sharedeventsmapdump(), which iterates over the same mapThread.yield()calls every 10 iterations increase lock contention between threadsConcurrentModificationException) is captured via anAtomicBooleanflagMotivation
This test validates the fix from PR #715 (
Avoid concurrent modification while dumping Profiler) by simulating the real-world scenario where one thread is logging/dumping profiler results while other threads are simultaneously recording checkpoints.Test Plan
Assisted-by: Hermes Agent:qwen36