Skip to content

Add support for PMMP 3.19.0 #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
supercrafter333 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add support for PMMP 3.19.0 #309

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7373591
Litle bug fix and prm protocol, version bump
supercrafter333 Apr 8, 2021
66a63c7
Another bug fix
supercrafter333 Apr 8, 2021
829ec88
Add new protocol
supercrafter333 Apr 8, 2021
977e699
Update README.md
supercrafter333 Apr 8, 2021
4e6fe0b
Update SlapperEntity.php
supercrafter333 Apr 10, 2021
6882ed1
Update SlapperEntity.php
supercrafter333 Apr 10, 2021
47537e0
Update plugin.yml
supercrafter333 Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/slapper/entities/SlapperEntity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
namespace slapper\entities;

use pocketmine\entity\Entity;
use pocketmine\item\Item;
use pocketmine\item\ItemFactory;
use pocketmine\item\ItemIds;
use pocketmine\level\Level;
Expand Down Expand Up @@ -60,7 +59,7 @@ protected function sendSpawnPacket(Player $player): void {
$pk2->uuid = UUID::fromRandom();
$pk2->username = $this->getDisplayName($player);
$pk2->position = $this->asVector3()->add(0, static::HEIGHT);
$pk2->item = ItemStackWrapper::legacy(Item::get(Item::AIR));
$pk2->item = ItemStackWrapper::legacy(Item::get(ItemIds::AIR));
Copy link
Copy Markdown

@TheNewHEROBRINEX TheNewHEROBRINEX Apr 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change Item::get back to ItemFactory::get

$pk2->metadata = [self::DATA_SCALE => [self::DATA_TYPE_FLOAT, 0.0]];

$player->dataPacket($pk2);
Expand Down