Skip to content

Fix PDF text-to-speech crashes #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4rdii wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix PDF text-to-speech crashes #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2521e0
tts: fix Intl.Segmenter crash on documents without lang metadata
4rdii Apr 11, 2026
01e801a
view: guard TTS scrollToAnchor for renderers that do not implement it
4rdii Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,12 @@ const getAlphabet = el => {
}

const getSegmenter = (lang = 'en', granularity = 'word') => {
const segmenter = new Intl.Segmenter(lang, { granularity })
// `lang` may be explicitly null when getLang() walks to the document
// root without finding a language attribute — common for PDFs, which
// almost never declare a language. The default parameter above only
// applies when the argument is `undefined`, not `null`, so we need a
// separate fallback here to avoid `Intl.Segmenter(null, ...)` throwing.
const segmenter = new Intl.Segmenter(lang || 'en', { granularity })
const granularityIsWord = granularity === 'word'
return function* (strs, makeRange) {
const str = strs.join('')
Expand Down
10 changes: 8 additions & 2 deletions view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,8 +585,14 @@ export class View extends HTMLElement {
const doc = this.renderer.getContents()[0].doc
if (this.tts && this.tts.doc === doc) return
const { TTS } = await import('./tts.js')
this.tts = new TTS(doc, textWalker, highlight || (range =>
this.renderer.scrollToAnchor(range, true)), granularity)
this.tts = new TTS(doc, textWalker, highlight || (range => {
// Not every renderer implements scrollToAnchor — in particular,
// the PDF renderer is fixed-layout and has no notion of an
// anchor to scroll to. Guard the call so that TTS still works
// on PDFs, just without sentence-highlight sync.
if (typeof this.renderer.scrollToAnchor === 'function')
this.renderer.scrollToAnchor(range, true)
}), granularity)
}
startMediaOverlay() {
const { index } = this.renderer.getContents()[0]
Expand Down