Skip to content

fix: bound the vault-MCP parity audit's CLI scan to its own subparser #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeseverino merged 1 commit into from
Jun 23, 2026
Merged

fix: bound the vault-MCP parity audit's CLI scan to its own subparser #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/audits/check-vault-mcp-parity.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,11 @@ function parseMcpUpdateFields(text) {
function parseCliUpdateFlags(text) {
const start = text.indexOf('"update-writeup"');
if (start === -1) fail('MCP cli.py is missing the update-writeup subcommand');
const end = text.indexOf('args = parser.parse_args()', start);
// Bound the scan to this one subparser — stop at the next `.add_parser(`.
// (cli.py builds the parser but never calls parse_args(); that lives in
// __main__.py, so anchoring on `args = parser.parse_args()` ran the slice to
// EOF and swept up every later subcommand's flags.)
const end = text.indexOf('.add_parser(', start + 1);
const block = text.slice(start, end === -1 ? text.length : end);
const fields = new Set();
for (const match of block.matchAll(/add_argument\("--([a-z][a-z-]*)"/g)) {
Expand Down
Loading