feat: brand-system cohesion — web-styles bundle, shared sync-tokens, lightbox buttons - #30
Merged
Merged
Conversation
The read/splice/render primitives now live upstream and are shared with the vault's Obsidian theme generator; bin/sync-tokens declares only its targets. Verified byte-identical output (already in sync).
Deploying jseverino with
|
| Latest commit: |
30e77c1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce61ca5e.jseverino.pages.dev |
| Branch Preview URL: | https://fix-lightbox-trigger-buttons.jseverino.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brand-system cohesion work (System Cohesion backlog 1.1) plus the branch's existing site changes:
brandVarsCss()(insrc/lib/brand.mjs) now owns the brand custom-property CSS once;/brand.css(src/pages/brand.css.ts) emits it instead of re-deriving. Newsrc/lib/web-styles.mjsexportspreviewStyles({baseCss,fontUrl})— base.css + brand vars + Inter @font-face as one blob — so an embedder can't forget the brand vars (the dead--color-primarythat cost a debugging session). Contract documented indocs/Brand-System.md. Output of/brand.cssis byte-identical.sync-tokensderivation fromseverino-brand/brand/sync.mjs, and real buttons for lightbox triggers.npm run check(css lint + css-vars audit + astro check) green locally.