fix(security): cierre de pendientes de auditoría P2/P3 del launcher#11
Merged
Conversation
A1: README sección Releasing reescrita — publish del launcher por CI con
provenance (OIDC), sin paso manual; aviso de no publicar a mano.
D0: keyword "database-client-terminal" en launcher/package.json.
B1: extracción in-process (launcher/extract.mjs: gunzip + parser ustar
propio, cero deps de runtime) reemplaza spawnSync("tar"). Rechaza path
traversal, symlinks/hardlinks que escapan, y cap anti gzip-bomb. Tests
en launcher/extract.test.ts. Override QUICK_OUTERBASE_BUNDLE intacto.
M1: gate de auditoría ENFORCED (scripts/audit-gate.mjs, --omit=dev,
fail-closed) + baseline documentado (.audit-allowlist.json, 21 GHSAs).
Bloquea CVE high+ NUEVOS en prod. check.yaml: npm install -> npm ci.
Verificado: 18/18 jest del launcher; round-trip byte-a-byte vs tar real
sobre bundle de 28MB (0 diffs); launcher e2e arranca server desde la
extracción in-process; gate verde/bloquea/fail-closed en las 3 direcciones.
Incluye fixes de review adversarial (2 fail-open critical en el gate,
cache parcial envenenado, PAX size negativo, gzip-bomb).
B2: name queda sin scope (decisión, sin cambio de código).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A1: README sección Releasing reescrita — publish del launcher por CI con
provenance (OIDC), sin paso manual; aviso de no publicar a mano.
D0: keyword "database-client-terminal" en launcher/package.json. B1: extracción in-process (launcher/extract.mjs: gunzip + parser ustar
propio, cero deps de runtime) reemplaza spawnSync("tar"). Rechaza path
traversal, symlinks/hardlinks que escapan, y cap anti gzip-bomb. Tests
en launcher/extract.test.ts. Override QUICK_OUTERBASE_BUNDLE intacto.
M1: gate de auditoría ENFORCED (scripts/audit-gate.mjs, --omit=dev,
fail-closed) + baseline documentado (.audit-allowlist.json, 21 GHSAs).
Bloquea CVE high+ NUEVOS en prod. check.yaml: npm install -> npm ci.
Verificado: 18/18 jest del launcher; round-trip byte-a-byte vs tar real sobre bundle de 28MB (0 diffs); launcher e2e arranca server desde la extracción in-process; gate verde/bloquea/fail-closed en las 3 direcciones. Incluye fixes de review adversarial (2 fail-open critical en el gate, cache parcial envenenado, PAX size negativo, gzip-bomb).
B2: name queda sin scope (decisión, sin cambio de código).