Add Azure Cloud Name support for sovereign cloud environments (e.g. AzureChinaCloud)#65
Merged
RobinDuhan merged 6 commits intojfrog:mainfrom Apr 17, 2026
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA
2877413 to
5eb5199
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
RobinDuhan
reviewed
Apr 13, 2026
RobinDuhan
reviewed
Apr 13, 2026
RobinDuhan
reviewed
Apr 13, 2026
RobinDuhan
reviewed
Apr 13, 2026
RobinDuhan
reviewed
Apr 13, 2026
RobinDuhan
requested changes
Apr 13, 2026
Contributor
Author
RobinDuhan
reviewed
Apr 14, 2026
Contributor
Author
|
Hi @RobinDuhan & @shahiinn , anything else to enhance? |
Contributor
|
Hey @chongwang87 , just checking again. I think we are mostly good to go. |
RobinDuhan
reviewed
Apr 15, 2026
Contributor
|
@chongwang87 Looks good besides that one comment on the ReadMe. Do you mind just verifying again, if you haven't already, since the PR did change quite a bit from the initial state? I think we are good to merge this tomorrow. We can release it early next week, Monday/Tuesday. |
RobinDuhan
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for configuring the Azure Cloud Name, enabling the credential provider to work in sovereign cloud environments such as Azure China (
AzureChinaCloud) in addition to the default Azure public cloud.Changes
Go application (
internal/)azure_cloud_nameconfiguration parameter to the providergetAzureADEndpoint()to resolve the correct Azure AD login endpoint based on cloud name (e.g.login.microsoftonline.comfor public,login.partner.microsoftonline.cnfor China)GetAzureOIDCTokento use the cloud-specific endpoint for token exchangeHelm chart (
helm/)azure_cloud_nametovalues.yamland the provider ConfigMap templateconfigmap-setup.yamlto handle download URLs containing query strings (e.g. SAS tokens) — arch suffix is now inserted before the query string instead of appended to the endDocumentation (
AZURE.md)Testing
Sample Helm chart values (Azure China)
Below are logs captured from kubelet