RTECO-1043 - Add HTTP_NOPROXY support in jfrog azure devops pipelines#600
Closed
RTECO-1043 - Add HTTP_NOPROXY support in jfrog azure devops pipelines#600
Conversation
agrasth
added
the
safe to test
github-actions
Bot
removed
the
safe to test
agrasth
changed the title
agrasth
added
the
safe to test
github-actions
Bot
removed
the
safe to test
…ually wrote HTTP_PROXY or HTTPS_PROXY. If the user had pre-existing proxy env vars (pointing to their own proxy), we return early without touching NO_PROXY. The agent's bypass list only applies to the agent's proxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.Summary
forwardProxyToEnv()forwardedAgent.ProxyUrlto
HTTP_PROXY/HTTPS_PROXYbut silently droppedAgent.ProxyBypassList, causing internal Artifactory connections tobe routed through the corporate proxy unexpectedly.
forwardProxyToEnv()now also forwardsAgent.ProxyBypassList→NO_PROXYso hosts configured for proxy bypass onthe ADO agent are respected by JFrog CLI without any manual pipeline changes.
Changes
jfrog-tasks-utils/utils.js— AddedNO_PROXYforwarding fromAgent.ProxyBypassListinforwardProxyToEnv().Honors existing
NO_PROXY/no_proxyenv vars (no override). Handles empty list and invalid JSON gracefully.tests/proxyConfigTest.js— Added 4 new tests covering: bypass list forwarded correctly, existingNO_PROXYnotoverridden, empty list produces no env var, invalid JSON warns and skips. Updated
clearProxyVars()to cleanNO_PROXY/no_proxybetween tests.