Add Valve-220 map format support to quemap.#831
Open
skies912 wants to merge 4 commits into
Open
Conversation
Auto-detects Valve-220 by peeking for '[' after the texture name; falls back to standard Q3 format if not present. Both formats are supported transparently with no flags required. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds transparent support for Valve-220 (“explicit texture axes”) brush-side texture mapping in quemap, auto-detecting Valve-220 syntax in .map files and adjusting texture vector generation accordingly to improve face alignment (e.g., in cavern).
Changes:
- Detect Valve-220 brush-side syntax during map parsing by peeking for
[after the texture name. - Add a
brush_side_t::valveflag and generate texture vectors differently when Valve-220 axes are present. - Print a simple “Map format” note during
qbspcompilation based on whether any Valve-220 sides were detected.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/quemap/map.c | Adds Valve-220 vs standard format detection and parsing for brush-side texture parameters. |
| src/quemap/map.h | Extends brush_side_t with a valve flag indicating Valve-220 axis usage. |
| src/quemap/texture.c | Adds Valve-220-specific texture vector handling using explicit axes. |
| src/quemap/qbsp.c | Prints the detected map format after loading the map. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-detects Valve-220 by peeking for '[' after the texture name; falls back to standard Q3 format if not present. Both formats are supported transparently with no flags required.
Ran into issues aligning faces in
cavern- this helps. TB support for patch editing is coming too, which will also help alot.