Clean up and fix consistency issues in buildscripts - #123
Conversation
double quotes are groovy strings, which have a small overhead to parse compared to single quotes, which are just java strings.
|
There were a few parts of this PR that I wasn't a fan of, and unfortunately too intertwined with the previous PRs, so I've split the single commit up into multiple so that they can be merged.
I've actually swapped everything to use single quotes unless it involves string interpolation. double quoted strings are Groovy Strings, which have an overhead for parsing, whereas single quoted strings are just raw Java strings.
I mentioned on discord that I know these were used but I didn't know where. I have since found out. if we remove the name though, we get Obviously with most mavens it will be clear what it actually is, like if the Fabric maven went down and a user got In general though I think including the name is good practice.
I don't think we need to list the fabric maven there, at-least I can build without it just fine |
0462291 to
01e7426
Compare
Changes:
Requires #122 to be merged first