Open
Conversation
Owner
|
Nice. Using the uid is a good idea and this is the right direction. But this implementation has a few problems: it overwrites the fixed serial prefix area, reads past the 12byte uid, and writes raw uid bytes directly into the serial field. 0EA prefix must stay unchanged. I will do it a bit differently: keep the 0EAx prefix, and generate a stable alphanumeric suffix from the UID once at boot. |
Author
|
okay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unique UID generation for each BMCU module to ensure distinct identification in Home Assistant and other multi-device setups.
Done! #59