Fix many warnings during build#2698
Conversation
There was a problem hiding this comment.
Code Review
This pull request modernizes the codebase by updating Gradle build scripts, adding generics to core utilities and rendering pipelines, and transitioning to newer FrameBuffer and Texture APIs. It also addresses compiler warnings and marks legacy methods as deprecated. Feedback focuses on critical API compatibility regressions in the Android modules where newer methods were introduced without version guards, potentially breaking support for older API levels. Additionally, several suggestions were provided to include @SuppressWarnings annotations on new helper methods to fully resolve unchecked cast warnings.
c7260b8 to
8b7d21a
Compare
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
fe423e7 to
bc3677f
Compare
c4186f3 to
5497b90
Compare
And also ban any new unchecked warnings with werror, so we don't have any regressions.
I know there are a decent number of suppressed ones in the repo, I will try to burn down some of those next.