Skip to content

Fix many warnings during build#2698

Open
8Keep wants to merge 4 commits intojMonkeyEngine:masterfrom
8Keep:warning-fixes
Open

Fix many warnings during build#2698
8Keep wants to merge 4 commits intojMonkeyEngine:masterfrom
8Keep:warning-fixes

Conversation

@8Keep
Copy link
Copy Markdown
Contributor

@8Keep 8Keep commented Apr 7, 2026

And also ban any new unchecked warnings with werror, so we don't have any regressions.

I know there are a decent number of suppressed ones in the repo, I will try to burn down some of those next.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modernizes the codebase by updating Gradle build scripts, adding generics to core utilities and rendering pipelines, and transitioning to newer FrameBuffer and Texture APIs. It also addresses compiler warnings and marks legacy methods as deprecated. Feedback focuses on critical API compatibility regressions in the Android modules where newer methods were introduced without version guards, potentially breaking support for older API levels. Additionally, several suggestions were provided to include @SuppressWarnings annotations on new helper methods to fully resolve unchecked cast warnings.

Comment thread jme3-android/src/main/java/com/jme3/app/AndroidHarness.java Outdated
Comment thread jme3-android/src/main/java/com/jme3/app/AndroidHarness.java Outdated
Comment thread jme3-android/src/main/java/com/jme3/app/AndroidHarnessFragment.java Outdated
Comment thread jme3-core/src/main/java/com/jme3/renderer/RenderContext.java
Comment thread jme3-core/src/main/java/com/jme3/util/IntMap.java
@8Keep 8Keep marked this pull request as draft April 8, 2026 00:06
@8Keep 8Keep force-pushed the warning-fixes branch 2 times, most recently from c7260b8 to 8b7d21a Compare April 8, 2026 00:07
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

🖼️ Screenshot tests have failed.

The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests.

📄 Where to find the report:

⚠️ If you didn't expect to change anything visual:
Fix your changes so the screenshot tests pass.

If you did mean to change things:
Review the replacement images in jme3-screenshot-tests/build/changed-images to make sure they really are improvements and then replace and commit the replacement images at jme3-screenshot-tests/src/test/resources.

If you are creating entirely new tests:
Find the new images in jme3-screenshot-tests/build/changed-images and commit the new images at jme3-screenshot-tests/src/test/resources.

Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar".

See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information

Contact @richardTingle (aka richtea) for guidance if required

@8Keep 8Keep changed the title Reduce Gradle and Android warning noise Reduce warning noise Apr 8, 2026
@8Keep 8Keep force-pushed the warning-fixes branch 3 times, most recently from fe423e7 to bc3677f Compare April 10, 2026 02:47
Comment thread jme3-android/src/main/java/com/jme3/app/AndroidHarnessFragment.java Outdated
Comment thread jme3-android/src/main/java/com/jme3/app/AndroidHarness.java Outdated
Comment thread jme3-android/src/main/java/com/jme3/app/AndroidHarness.java Outdated
Comment thread jme3-core/src/main/java/com/jme3/effect/ParticleEmitter.java
@8Keep 8Keep marked this pull request as ready for review April 10, 2026 18:48
@8Keep 8Keep force-pushed the warning-fixes branch from bc3677f to a3c460b Compare May 9, 2026 07:23
@8Keep 8Keep marked this pull request as draft May 9, 2026 07:42
@8Keep 8Keep force-pushed the warning-fixes branch from a3c460b to 831314c Compare May 9, 2026 07:45
@8Keep 8Keep force-pushed the warning-fixes branch 2 times, most recently from c4186f3 to 5497b90 Compare May 9, 2026 08:23
@8Keep 8Keep force-pushed the warning-fixes branch from 5497b90 to 89249ce Compare May 9, 2026 08:32
@8Keep 8Keep changed the title Reduce warning noise Fix all unchecked warnings + ban future ones May 9, 2026
@8Keep 8Keep changed the title Fix all unchecked warnings + ban future ones Fix many warnings during build May 9, 2026
@8Keep 8Keep marked this pull request as ready for review May 9, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant