fix(serve): Return 400 for invalid YAML/schema instead of 500#9
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(serve): Return 400 for invalid YAML/schema instead of 500#9sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when users submitted malformed YAML content or data that didn't conform to the
NurseSchedulingDataschema to the/optimize-and-export-xlsxendpoint, the server would catch these parsing/validation errors with a broadexcept Exceptionblock. This resulted in anHTTPExceptionwith a 500 status code, incorrectly indicating a server-side error, even though the issue stemmed from invalid client input.This PR refines the error handling in
core/nurse_scheduling/serve.py:ruamel.yaml.YAMLErrorfor malformed YAML input, returning anHTTPExceptionwith a 400 status code and a sanitized error message (to prevent leaking internal details).pydantic.ValidationErrorfor data that fails schema validation, returning anHTTPExceptionwith a 400 status code and a summary of the validation errors.except Exceptionblock is retained as a fallback for truly unexpected server-side errors, which will continue to result in a 500 status code.This change improves the API's robustness and user experience by providing more accurate HTTP status codes and clearer error messages for client-side input issues.
Fixes JAVASCRIPT-NEXTJS-6