fix(api): Return 400 for preference validation ValueErrors#23
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(api): Return 400 for preference validation ValueErrors#23sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #23 +/- ##
==========================================
- Coverage 92.12% 92.06% -0.06%
==========================================
Files 46 46
Lines 3300 3303 +3
Branches 458 458
==========================================
+ Hits 3040 3041 +1
- Misses 161 163 +2
Partials 99 99
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
ValueErrorexceptions raised during preference validation (e.g., a positive weight for ashift countpreference with|x - T|^2expression) were caught by the genericexcept Exceptionblock incore/nurse_scheduling/serve.py. This resulted in an HTTP 500 server error and an error-level log in Sentry, despite the issue being a client-side input validation failure.This change introduces a specific
except ValueErrorblock in the/optimize-and-export-xlsxhandler. It now catches these validation-relatedValueErrors, logs them at a warning level, and returns an HTTP 400 Bad Request to the client. This aligns the handling of these errors with other client-side validation issues (likeNotImplementedErrorandValidationError), providing clearer feedback to the user and preventing unnecessary server error reports.Fixes NURSE-SCHEDULING-16