Add tooling to allow for user-defined post question pick command#351
Open
john-d-murphy wants to merge 3 commits intoj178:masterfrom
Open
Add tooling to allow for user-defined post question pick command#351john-d-murphy wants to merge 3 commits intoj178:masterfrom
john-d-murphy wants to merge 3 commits intoj178:masterfrom
Conversation
Owner
|
Thanks for your PR! I’m unavailable to review it at the moment, but I’ll get back to it in about a week. Thanks for your patience! |
Author
No problem! Whenever you're ready. I realized I needed to write the code for my use case, and I figured I'd share. Absolutely no rush, and I'm happy to describe how/why I'm using it when you're ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For CPP files, I found that I needed an extra file in my code folder to prevent my editor's code anaylsis from throwing spurious warnings.
It makes sense to copy this file into the code folder after every pick action, and it also makes sense to not have this hard-coded since other people's dev environments may be different.
Therefore, this PR allows a user to set thier own default action to take after a pick action has been completed.
I'm happy to make any edits to this or to have this thrown out - it's my first bit of Go code and I'm not sure if this even warrants a feature request.
For context, I'm using this to push build commands and a test framework to each problem so I can do a build and test on a given problem's tests in vim directly.