fix(ui): nothing appears on lists#10
Open
leocavalcante wants to merge 1 commit intoivanjm3:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes targeted improvements to the UI update logic, specifically addressing how window resizing is handled and fixing a bug in the reply quoting functionality. The main changes are:
UI resizing logic simplification:
handleResizemethod inui/update.goby removing the switch statement and consistently resizing bothemailListandlabelList, ensuring they always match the window size. This reduces complexity and potential bugs when switching between states.Bug fix in reply quoting:
m.replyTo.Body) instead of the currently viewed email (m.currentEmail.Body). This ensures the reply includes the intended original message.Closes #9