Skip to content

Fix for integer-overflow in ixheaacd_invert_matrix #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SakethSathuvalli merged 1 commit into from
Feb 3, 2026
Merged

Fix for integer-overflow in ixheaacd_invert_matrix #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions decoder/ixheaacd_mps_calc_m1m2_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,13 @@ VOID ixheaacd_invert_matrix(WORD32 weight1, WORD32 weight2, WORD32 h_real[][2],

WORD64 acc1, acc2;

len1 = ixheaacd_mps_sqrt((ONE_IN_Q15 - (weight1 << 1) + ((weight1 * weight1) >> 14)), &q_len1,
common_tab_ptr->sqrt_tab);
len1 = ixheaacd_mps_sqrt(
(ONE_IN_Q15 - (weight1 << 1) + ixheaacd_mps_mult32_shr_n(weight1, weight1, 14)), &q_len1,
common_tab_ptr->sqrt_tab);

len2 = ixheaacd_mps_sqrt((ONE_IN_Q15 - (weight2 << 1) + ((weight2 * weight2) >> 14)), &q_len2,
common_tab_ptr->sqrt_tab);
len2 = ixheaacd_mps_sqrt(
(ONE_IN_Q15 - (weight2 << 1) + ixheaacd_mps_mult32_shr_n(weight2, weight2, 14)), &q_len2,
common_tab_ptr->sqrt_tab);

len1 = ixheaacd_mps_convert_to_qn(len1, q_len1, 15);
len2 = ixheaacd_mps_convert_to_qn(len2, q_len2, 15);
Expand All @@ -143,7 +145,7 @@ VOID ixheaacd_invert_matrix(WORD32 weight1, WORD32 weight2, WORD32 h_real[][2],

h11_f_imag = ixheaacd_mps_div32_in_q15(weight1, len1);

h22_f_imag = -(ixheaacd_mps_div32_in_q15(weight2, len2));
h22_f_imag = ixheaac_negate32_sat(ixheaacd_mps_div32_in_q15(weight2, len2));

h12_f_real = 0;

Expand Down