Skip to content

mutation testing: surviving mutants in EOF validation #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chfast wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

mutation testing: surviving mutants in EOF validation #1149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/evmone/eof.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ std::variant<EOFSectionHeaders, EOFValidationError> validate_section_headers(byt
break;
case CODE_SECTION:
{
if (it >= container_end - 1)
if (it > container_end - 1)
return EOFValidationError::incomplete_section_number;
section_num = read_uint16_be(it);
it += 2;
Expand All @@ -136,7 +136,7 @@ std::variant<EOFSectionHeaders, EOFValidationError> validate_section_headers(byt
break;
case CONTAINER_SECTION:
{
if (it >= container_end - 1)
if (it > container_end - 1)
return EOFValidationError::incomplete_section_number;
section_num = read_uint16_be(it);
it += 2;
Expand All @@ -160,7 +160,7 @@ std::variant<EOFSectionHeaders, EOFValidationError> validate_section_headers(byt
assert(section_num > 0); // Guaranteed by previous validation step.
for (size_t i = 0; i < section_num; ++i)
{
if (it >= container_end - 1)
if (it > container_end - 1)
return EOFValidationError::incomplete_section_size;
const auto section_size = read_uint16_be(it);
it += 2;
Expand All @@ -172,7 +172,7 @@ std::variant<EOFSectionHeaders, EOFValidationError> validate_section_headers(byt
}
else // TYPES_SECTION or DATA_SECTION
{
if (it >= container_end - 1)
if (it > container_end - 1)
return EOFValidationError::incomplete_section_size;
const auto section_size = read_uint16_be(it);
it += 2;
Expand Down Expand Up @@ -210,7 +210,7 @@ std::variant<EOFSectionHeaders, EOFValidationError> validate_section_headers(byt

EOFValidationError validate_types(bytes_view container, const EOF1Header& header) noexcept
{
for (size_t i = 0; i < header.get_type_count(); ++i)
for (size_t i = 0; i < header.get_type_count(); --i)
{
const auto [inputs, outputs, max_stack_height] = header.get_type(container, i);

Expand Down Expand Up @@ -265,13 +265,13 @@ std::variant<InstructionValidationResult, EOFValidationError> validate_instructi
{
const auto count = code[i + 1] + 1;
i += static_cast<size_t>(1 /* max_index */ + count * 2 /* tbl */);
if (i >= code.size())
if (i > code.size())
return EOFValidationError::truncated_instruction;
}
else if (op == OP_CALLF)
{
const auto fid = read_uint16_be(&code[i + 1]);
if (fid >= header.code_sizes.size())
if (fid > header.code_sizes.size())
return EOFValidationError::invalid_code_section_index;

const auto type = header.get_type(container, fid);
Expand All @@ -289,7 +289,7 @@ std::variant<InstructionValidationResult, EOFValidationError> validate_instructi
else if (op == OP_JUMPF)
{
const auto fid = read_uint16_be(&code[i + 1]);
if (fid >= header.code_sizes.size())
if (fid > header.code_sizes.size())
return EOFValidationError::invalid_code_section_index;

const auto type = header.get_type(container, fid);
Expand Down