fix: make the kubo binary reliably available#3180
Open
lidel wants to merge 4 commits into
Open
Conversation
Parked until kubo is bumped to the npm-kubo release that fetches from GitHub releases (ipfs/npm-kubo#83). The current kubo still uses the dist.ipfs.tech layout, so do not merge before that bump.
Temporary: point the kubo dependency at the ipfs/npm-kubo#83 branch over git+https so CI clones it and exercises the GitHub-releases fetch end to end. Revert to a published kubo version before merging.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
lidel
changed the title
Bump the pinned npm-kubo commit to the one that creates bin/ before linking, so CI's git install no longer fails. Revert with the rest of the test wiring before merge.
ipfs/npm-kubo#83 (on-demand binary fetch from github releases) landed on master. Pin the kubo dependency to the latest npm-kubo master commit and drop the macos build TODO that was gating the switch.
lidel
force-pushed
the
chore/kubo-from-github-releases
branch
from
26f1450 to
5d8ec8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two problems, both in how ipfs-desktop gets the kubo binary:
postinstallscript, so it never lands when npm skips that script (--ignore-scripts, pnpm, hardened CI, and the upcoming npm v12 default). The app then shows "kubo binary not found" and the daemon won't start (Error: kubo binary not found #3031).Fix
Adopt the new
kubo(ipfs/npm-kubo#83), which tackles both:The macOS universal build moves to GitHub too. The kubo version is unchanged; see the npm-kubo PR for details. CI tracks the branch for now and will pin a published version before merge.
TODO before merging this