Move admin to stable and remove chai from deps#5943
Closed
GermanBluefox wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the repo tests and metadata to reflect moving admin to stable while removing chai from dev dependencies.
Changes:
- Replace
chaiassertions with Node’s built-inassertin the test suite. - Bump the stable
adminversion insources-dist-stable.json. - Remove
chaiand bumpaxiosinpackage.json.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/testRepo.js | Migrates assertions from chai to Node assert and adjusts admin name exception logic. |
| sources-dist-stable.json | Updates the stable admin adapter version. |
| package.json | Removes chai and updates the axios devDependency version. |
| @@ -1,5 +1,5 @@ | |||
| 'use strict'; | |||
| const expect = require('chai').expect; | |||
| const assert = require('node:assert'); | |||
Comment on lines
+71
to
+72
| assert.equal(id, id.toLowerCase(), `Adapter id ${id} is not lowercase`); | ||
| assert.notEqual(latest[id], undefined, `${id} not in latest but in stable`); |
Comment on lines
31
to
36
| try { | ||
| latest = JSON.parse(text); | ||
| } catch (e) { | ||
| expect(e).to.be.null; | ||
| assert.equal(e, null, 'Error parsing sources-dist.json'); | ||
| } | ||
| done(); |
github-actions
Bot
added
auto-checked
Contributor
Automated adapter checkerioBroker.admin
ERRORS:
WARNINGS:
SUGGESTIONS:
Adapter releases: https://www.iobroker.dev/adapter/ioBroker/ioBroker.admin/releases History and usage information for release 7.8.23: 7.8.23 created 27.4.2026 (7 days old) 7.7.22 (stable) created 15.12.2025 (140 days old) Please verify that this PR really tries to update to release 7.8.23! Add comment "RE-CHECK!" to start check anew |
Collaborator
|
Please do not mix adapter versionnupdates and changescto code at iobroker.repositories at ONE Pr. create ONE seperste PR for every Adapter which should be added or whoch version should be bumped at stable. Do not update more than one Adapter within one PR. Code changes need a seperste PR in all cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.