Implement runtime filter for asset archiving#498
Draft
Copilot wants to merge 3 commits into
Draft
Conversation
- Add configuration options for max assets, file type filtering, and timeout - Implement filterAssets function in postprocessor - Add command-line flags for asset filtering - Add comprehensive tests for asset filtering logic - Modify archiver to support timeout-based asset archiving Co-authored-by: CorentinB <5089772+CorentinB@users.noreply.github.com>
…documentation - Add integration tests for combined filtering scenarios - Add configuration validation tests - Fix test cases for proper edge case handling - Add comprehensive documentation with examples - All features working as designed with default behavior preserved Co-authored-by: CorentinB <5089772+CorentinB@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement runtime filter for asset archiving
Implement runtime filter for asset archiving
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements runtime filters for asset archiving as requested, allowing users to limit asset archiving by number, file type, and time spent per page.
New Features
1. Maximum Assets Limit (
--max-assets)Limits the number of assets archived per page:
2. File Type Filtering
Control which asset types to archive:
3. Time-Based Filtering (
--assets-archiving-timeout)Stop archiving assets after a specified time per page:
Implementation Details
Combined Usage
All filters can be combined for fine-grained control:
Testing
The implementation includes comprehensive test coverage:
Fixes #388.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
example.com./Zeno get url REDACTED --max-assets 2 --assets-allowed-file-types css,js --log-level debug --workers 1(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.