fix: prevent popup scrollbar when browser zoom exceeds 100%#1346
fix: prevent popup scrollbar when browser zoom exceeds 100%#1346Onyx2406 wants to merge 1 commit into
Conversation
When browser zoom is above 100%, the popup's fixed 600px height exceeds the available viewport, causing an unwanted scrollbar. Add `max-h-screen` to cap the popup container at the actual viewport height regardless of zoom level, and `overflow-hidden` to prevent the outer scrollbar. The main content area gets `overflow-y-auto` so content remains accessible when it exceeds the available space. Closes interledger#1014
|
Can you confirm this PR addresses issues mentioned in #1211 as well? |
|
Thanks for pointing to #1211! I reviewed the feedback there — the previous approach removed My approach is different — I keep
The popup never dynamically resizes based on content — it's always either 600px or the viewport height, whichever is smaller. This should avoid the issues from #1211. That said, I haven't been able to test whether the advanced section / wallet info screen still looks correct at high zoom. Happy to adjust if there are specific screens that need attention. |


Summary
Fixes the popup showing an unwanted scrollbar when browser zoom level is above 100%.
Root cause: The popup container has a fixed height of 600px (
h-popup), but when browser zoom exceeds 100%, the available viewport in CSS pixels shrinks below 600px, causing overflow.Fix:
max-h-screento the popup container — caps height at the actual viewport height regardless of zoom leveloverflow-hiddento the container — prevents the outer scrollbaroverflow-y-autoto the<main>content area — keeps content accessible via scoped scrolling when it overflows (e.g., error states with long content)This ensures the header and divider remain fixed at top while content scrolls naturally within the available space.
Changes
src/pages/popup/components/layout/MainLayout.tsxmax-h-screen overflow-hiddento container,overflow-y-autoto mainTest plan
Closes #1014