Skip to content

fix key signing #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonathanMatthey merged 1 commit into from
Apr 27, 2026
Merged

fix key signing #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
# GitHub App (installation must have "Issues: write" on interledger/open-payments-docs-feedback)
GITHUB_APP_ID=
GITHUB_APP_INSTALLATION_ID=
# Either set PEM inline (Netlify: use literal \n for newlines) or point to a local file
# Either set PEM inline or point to a local file. Netlify: one line, literal \n for PEM
# line breaks; do not wrap the value in extra "quotes" (breaks OpenSSL).
GITHUB_APP_PRIVATE_KEY=
GITHUB_APP_PRIVATE_KEY_PATH=
PUBLIC_FEEDBACK_FUNCTION_URL=/.netlify/functions/feedback
25 changes: 21 additions & 4 deletions docs/netlify/functions/feedback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,21 @@ const readLocalEnvVar = (name: string) => getLocalEnvFromDisk()?.map.get(name)

const getEnv = (name: string) => process.env[name] || readLocalEnvVar(name)

const normalizePrivateKey = (raw: string) => raw.trim().replace(/\\n/g, '\n')
/** Netlify / dashboards often add BOM, quotes, or CRLF around PEM secrets */
const normalizePrivateKey = (raw: string) => {
let s = raw.trim().replace(/^\uFEFF/, '')
if (
(s.startsWith('"') && s.endsWith('"')) ||
(s.startsWith("'") && s.endsWith("'"))
) {
s = s.slice(1, -1)
}
return s
.replace(/\\n/g, '\n')
.replace(/\r\n/g, '\n')
.replace(/\r/g, '\n')
.trimEnd()
}

const loadPrivateKeyPem = (): string | undefined => {
const inline = getEnv('GITHUB_APP_PRIVATE_KEY')
Expand Down Expand Up @@ -202,8 +216,10 @@ export const handler = async (event: NetlifyEvent) => {
})
}

const appId = getEnv('GITHUB_APP_ID')
const installationId = getEnv('GITHUB_APP_INSTALLATION_ID')
const appId = stripEnvValueQuotes(getEnv('GITHUB_APP_ID')?.trim() ?? '')
const installationId = stripEnvValueQuotes(
getEnv('GITHUB_APP_INSTALLATION_ID')?.trim() ?? ''
)
const privateKey = loadPrivateKeyPem()

if (!appId || !installationId || !privateKey) {
Expand Down Expand Up @@ -239,7 +255,8 @@ export const handler = async (event: NetlifyEvent) => {
} catch {
return createResponse(500, {
success: false,
error: 'Could not sign GitHub App JWT'
error:
'Could not sign GitHub App JWT (check GITHUB_APP_PRIVATE_KEY: use PEM with \\n newlines, no wrapping quotes, same key as the app)'
})
}

Expand Down
Loading