Add initial configurations for the fbgemm-xpu package#70
Open
flezaalv wants to merge 30 commits into
Open
Conversation
Adds BSD 3-Clause license (Copyright 2026 Intel Corporation) for the fbgemm-xpu package and third-party-programs.txt documenting the original FBGEMM software license from Meta Platforms, Inc. Ensures proper legal attribution for derivative work.
- Implements setuptools configuration for building fbgemm XPU operators with Intel SYCL backend. - NOTE: setup.py will be replaced by toml build system for torchlib-xpu integration in a future PR. So far setup.py is needed to build fbgemm-xpu independently to run tests.
Adds temporary build system
…ctions in cmake to include all cpp files
…ild-files-to-toml-and-cmake
dvrogozh
reviewed
Jun 9, 2026
dvrogozh
reviewed
Jun 10, 2026
|
|
||
| target_compile_options(_C PRIVATE | ||
| -fdiagnostics-color=always | ||
| -Wno-c++11-narrowing |
Contributor
There was a problem hiding this comment.
-Wno-c++11-narrowing - why? I would prefer to add any warning suppressions in the PR which actually adds the code.
dvrogozh
reviewed
Jun 11, 2026
Co-authored-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
Co-authored-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
Co-authored-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
Co-authored-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
Co-authored-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
dvrogozh
reviewed
Jun 16, 2026
| fbgemm_utils/*.cpp | ||
| ) | ||
|
|
||
| # CMake does not recognize the .sycl extension as a C++ source. Mirror every |
Contributor
There was a problem hiding this comment.
Maybe we will just implement sycl kernels in the *.cpp files? We can separate them out into the sycl/ folder if needed to avoid intermix with the regular *.cpp files.
| # -------------------------------------------------------------------------- | ||
| # Auto-include all host C++ sources in this directory. | ||
| file(GLOB host_sources CONFIGURE_DEPENDS | ||
| *.cpp |
Contributor
There was a problem hiding this comment.
To be honest I would prefer to have explicit list of files to build rather than wildcards. That's current consensus across the ecosystem that explicit is always better.
Co-authored-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
Co-authored-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the fbgemm-xpu build and packaging foundation to use a pyproject.toml + CMake setup.
It also adds/updates package metadata (README, license, manifest, versioning, and third-party notices), introduces an initial operator template, and updates dependencies and installation instructions on XPU environments.
Follow the README instructions to build fbgemm-xpu package.
CC: @aagalleg @manuelhsantana